[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#819850: RFS: passwordsafe/0.98.1+dfsg-2



Hi Bill, unfortunately your package fails to build from source with -Wl,--as-needed flags
(the default e.g. in Ubuntu).

the attached patch fixes the issue, please let me know if I can upload it on Debian (of course after changing the revision)

--- passwordsafe-0.98.1+dfsg.orig/src/test/Makefile
+++ passwordsafe-0.98.1+dfsg/src/test/Makefile
@@ -26,7 +26,7 @@ TEST   = $(BINPATH)/coretest
 OBJ         = $(TESTOBJ) $(LIBOBJ)

 CXXFLAGS += -DUNICODE -Wall -I$(INCPATH) -std=c++11
-LDFLAGS   = -L$(LIBPATH) -lcore -luuid -los -lcore -lxerces-c -pthread
+LDFLAGS   = -L$(LIBPATH) -lcore -los -luuid -lxerces-c -pthread

 # rules
 .PHONY: all clean test run setup


basically uuid is needed for core and os libraries, so it should be the last one, otherwise it will be stripped by the linker
because of "unneeded".

you can also grab the patch from the Ubuntu upload
http://launchpadlibrarian.net/251858702/passwordsafe_0.98.1+dfsg-2_0.98.1+dfsg-2ubuntu1.diff.gz

cheers,

Gianfranco
diff -Nru passwordsafe-0.98.1+dfsg/debian/changelog passwordsafe-0.98.1+dfsg/debian/changelog
--- passwordsafe-0.98.1+dfsg/debian/changelog	2016-04-03 03:37:24.000000000 +0200
+++ passwordsafe-0.98.1+dfsg/debian/changelog	2016-04-05 18:04:20.000000000 +0200
@@ -1,3 +1,9 @@
+passwordsafe (0.98.1+dfsg-2ubuntu1) xenial; urgency=medium
+
+  * fix build with -Wl,--as-needed
+
+ -- Gianfranco Costamagna <locutusofborg@debian.org>  Tue, 05 Apr 2016 16:32:43 +0200
+
 passwordsafe (0.98.1+dfsg-2) unstable; urgency=medium
 
   * Fix logic error in date conversion.  Fixes automated test
diff -Nru passwordsafe-0.98.1+dfsg/debian/patches/fix-link passwordsafe-0.98.1+dfsg/debian/patches/fix-link
--- passwordsafe-0.98.1+dfsg/debian/patches/fix-link	1970-01-01 01:00:00.000000000 +0100
+++ passwordsafe-0.98.1+dfsg/debian/patches/fix-link	2016-04-05 17:56:39.000000000 +0200
@@ -0,0 +1,14 @@
+Description: fix link failure with -Wl,--as-needed
+Author: Gianfranco Costamagna <locutusofborg@debian.org>
+
+--- passwordsafe-0.98.1+dfsg.orig/src/test/Makefile
++++ passwordsafe-0.98.1+dfsg/src/test/Makefile
+@@ -26,7 +26,7 @@ TEST	 = $(BINPATH)/coretest
+ OBJ	     = $(TESTOBJ) $(LIBOBJ)
+ 
+ CXXFLAGS += -DUNICODE -Wall -I$(INCPATH) -std=c++11
+-LDFLAGS   = -L$(LIBPATH) -lcore -luuid -los -lcore -lxerces-c -pthread
++LDFLAGS   = -L$(LIBPATH) -lcore -los -luuid -lxerces-c -pthread
+ 
+ # rules
+ .PHONY: all clean test run setup
diff -Nru passwordsafe-0.98.1+dfsg/debian/patches/series passwordsafe-0.98.1+dfsg/debian/patches/series
--- passwordsafe-0.98.1+dfsg/debian/patches/series	2016-04-03 03:37:24.000000000 +0200
+++ passwordsafe-0.98.1+dfsg/debian/patches/series	2016-04-05 17:51:18.000000000 +0200
@@ -1,3 +1,4 @@
 edit_paths
 version_fix
 gmtime_fix
+fix-link

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: