Bug#811073: RFS: lbfgsb/3.0-1 [ITP]
On Friday 25 March 2016 18:56:40 Gianfranco Costamagna wrote:
> Hi,
Hi, and thanks for the feedback!
> something needs changes:
> - std-version= 3.9.7
Yep, I'll update that.
> - no watch file?
I didn't make one since upstream's tarball (at least for the latest
version) contains precompiled binaries, as well as a few files outside
of any directory (a little tarbomb). It is my understanding that these
need to be stripped out of the Debian source. Should I make a script
for that and have uscan run it?
Upstream has a very slow release cycle, and it is my impression that
the library is more or less "done". Is a watch file still important?
> - no sane build system, why are you building the library such way?
There is no build system upstream. How should I best approach this
issue?
> you seem to use just two files in your library, why everything is dropped?
The following source files are not used:
- blas.f: We use the system libblas instead of this bundled copy.
- driver*.f*: These are demonstration files for how to use the
library, and are therefore not compiled. Should they be installed
as example source files somewhere?
- linpack.f: We use the system liblapack instead of this bundled
LINPACK. See also debian/patches/replace-linpack-with-lapack.patch.
That leaves only lbfgsb.f and timer.f, as you say. The former contains
the entire substance of the library.
> I don't think flags in rules are actually evaluated, because you
> don't set them
Thank you, I'll look into that.
> - dbg package is useless now that we have ddbg automatic generation.
Will fix. Thanks.
Best,
Gard
Reply to: