[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#816004: RFS: [ITP] python-nameparser/0.3.11-1



On Sun, Mar 20, 2016 at 08:35:13AM +0000, Edward Betts wrote:
> Mattia Rizzolo <mattia@debian.org> wrote:
> > * dist/*:
> >   + why on the earth is that directory filled with tarballs of old
> >     releases?  Please ask upstream to stop shipping such tarballs, or
> >     (maybe better), why not using the tarballs he's providing on pypi,
> >     which seem to be nicer?
> >     In that case please use http://pypi.debian.net/nameparser/watch
> 
> The tarball uploaded to pypi is missing the unit tests. These seems to be a
> common problem with Python modules.

yes it is.  Indeed I've not noticed the testsuite was missing in the
tarball on pypi.

> The upstream developer feels like the
> tests are only needed by people working on the code, not for the end user.

:(

> I think it is useful to run the tests when the Debian package is built and
> possible have autopkgtest run the tests as well.

Yes, it's actually important, I'd say.
Given that the dependencies of packages changes fairly often, as does
the python version used, it's not uncommon that tests start to fail out
of a suddent, and it's usually a symptom of something broken.

> I will write to the upstream author and attempt to convince them that the
> tests should be included in the pypi tarball. I tried this for the
> django-jinja package, but upstream wasn't interested. Do you have any other
> ideas, is there a way I could build the package from the pypi but included the
> tests which are only in github?

There is, you could use the multi-tarball feature of source format 3.0,
but it's a pain to use, and there is no nice way to keep everything in
git, IOW: don't use it unless you really need to, and this is not the
case.

Given that what I'm mainly complaining here is the presence of all those
old releases compressed inside dist/* that I can't figure what they are
for, have you tried asking upstream to just delete them?

otherwise, imho this is a good case for repacking the tarball using a
version with +ds.

To be clear, the main problem with those tarballs is that I'm (and you
too, and ftpmasters are too) supposed to unpack all of them and check if
all the files in all of them are free.  Not to say that it is a complate
waste of space...
-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  http://mapreri.org                              : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

Attachment: signature.asc
Description: PGP signature


Reply to: