On Fri, Mar 11, 2016 at 08:10:40PM +0000, Jose M Calhariz wrote:
> I managed to remove some lines from *.dirs.
cool.
> > * do you know why dh_makeshlibs is called with --noscripts?
> It silence a lintian warning "amanda-common:
> postinst-has-useless-call-to-ldconfig"
umh, I wonder why dh adds the trigger, then.
Well, I think I'm going to ignore this particular thing and postpone it
to the new version where several other things will change.
> > * on a site note, do you know that the nice thing of using variables
> > with only one letter in a makefile makes possible to just use $c
> > instead of $(c) ? :)
> I don't like that and I don't like this 3 variable names, so they will
> go away on next upstream release.
even better!
> > * d/copyright looks outdated, at least with regards to years. Also, I'd
> > love to see a DEP-5 compliant copyright file
> I don't know how to identify what license is used on Amanda.
The license is correctly reported on most of the headers, and in
/COPYRIGHT. It's a MIT-like license, unluckily not Expat.
If I were you I'd probably use the name 'custom' for it.
> I don't know what license was used to create the debian package. Should
> I contact the previous DD that worked on this?
I'm positive bdale intended to use the same license as upstream, yes,
contacting him is better. He is usually responsive (at least via IRC).
(clearly I'm talking about bdale, I think it's safe to assume the other
are ok with that license).
Please address this thing of the copyright and then I'm good to upload
it :)
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: http://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature