Hi, I have a few comments on this pavkage. Firstly although it's clear you've put some work into this, I'm not so sure packaging this client is that useful. I'm using Google Chrome, and going to www.runescape.com and clicking "Play Now" launches the client (through an external jar which autolaunches). Does this package do anything more than that? When a linux runescape client is mentioned, it's usually referring to Hikari Knight's client which has lots of other features - https://launchpad.net/rsu-client On the upstream code: rs-lang/*: * Downloading over http is a security risk - use https. * Why not use $(mktemp -d)? * There's a lot of duplication between the files here which could be improved. On the packaging itself: d/README.Debian: * If you haven't changed the original source at all, you don't need this file. d/control: * Since the program downloads non-free jars and executes them, the package must go into contrib and not main. * I think you've got the Build-Depends and Depends fields mixed up. Surely you need default-jre to RUN runescape rather than build the debian package? * The short description doesn't mention that this is a game. * The extended description should mention the non-freeness of the game itself. d/copyright: * I'm not sure any of this code is copyright Jagex. Please use the correct Source and Files: * copyright. * Copyright is needed for runescape.xpm. I suspect this image is non- free. * Do not use "GPL-2" as the shortname if the license is not exactly the GPL-2. * You could probably shorten that section a bit with a reference to the common license in /usr/share/common-licenses. d/rules: * The rules are very overcomplicated for what the package need to do. You could probably replace all of it with "%: dh $@". d/runescape-docs.docs: * This file does nothing. Thanks, James
Attachment:
signature.asc
Description: This is a digitally signed message part