[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#808141: sponsorship-requests: Dear mentors, I am looking for a sponsor for my package eclipse-titan.



On Tue, Jan 26, 2016 at 12:19:09PM +0100, Jakub Wilk wrote:
> * Pilisi Gergely <mail.pilisig@gmail.com>, 2016-01-22, 14:55:
> >export DEB_BUILD_MAINT_OPTIONS = hardening=+all
> >export CPPFLAGS=$(shell dpkg-buildflags --get CPPFLAGS)
> >export CFLAGS=$(shell dpkg-buildflags --get CFLAGS)
> >export CXXFLAGS=$(shell dpkg-buildflags --get CXXFLAGS)
> >export LDFLAGS=$(shell dpkg-buildflags --get LDFLAGS)
> 
> Note that $(shell) constructs are not affected by variables exported in the
> same makefile.
> 
> >export CCFLAGS=$(shell dplg-buildflags --get CFLAGS)
> 
> Typo: s/dplg/dpkg/.

oh, thank you, indeed!
Your email made me try some more, and I get a better state in blhc.
I noticed that the faulty flag is pie-related.
I applied this:

--- eclipse-titan-5.4.1/debian/rules	2016-01-22 13:30:30.000000000 +0000
+++ eclipse-titan-5.4.1/debian/rules	2016-01-26 23:42:37.000000000 +0000
@@ -1,12 +1,9 @@
 #!/usr/bin/make -f
 export V=1
 export DH_VERBOSE=1
-export DEB_BUILD_MAINT_OPTIONS = hardening=+all
-export CPPFLAGS=$(shell dpkg-buildflags --get CPPFLAGS)
-export CFLAGS=$(shell dpkg-buildflags --get CFLAGS)
-export CXXFLAGS=$(shell dpkg-buildflags --get CXXFLAGS)
-export LDFLAGS=$(shell dpkg-buildflags --get LDFLAGS)
-export CCFLAGS=$(shell dplg-buildflags --get CFLAGS)
+
+export DEB_BUILD_OPTIONS=hardening=+all,-pie
+export CCFLAGS = $(shell DEB_BUILD_OPTIONS=hardening=+all,-pie dpkg-buildflags --get CFLAGS)
 
 %:
 	dh $@ --verbose --parallel

Which I like some more than your version (I want to remember you that
debhlper with compat 9+ exports those flags by itself, except CCFLAGS
which is non-standard)

Still, I couldn't carry this thing further.
Given that I like this more, can I upload this instead? :)

> >What is wrong with that? :(
> 
> blhc(1) is invaluable for debugging hardening issues.

Yeah, I do use it, even if usually the thing I fixed in the past were
quite easy to fix and I had ever had the need to look at its output
closer than just glancing over it.

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  http://mapreri.org                              : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

Attachment: signature.asc
Description: PGP signature


Reply to: