[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#802298: RFS: php-htmlawed/1.1.20-2 [ITP] -- htmLawed PHP code to purify & filter HTML

On Saturday 02 January 2016 04:38 PM, Mattia Rizzolo wrote:
> On Mon, Oct 19, 2015 at 12:37:22PM +0530, Bhuvan Krishna wrote:
>> http://mentors.debian.net/debian/pool/main/p/php-htmlawed/php-htmlawed_1.1.20-2.dsc
> a review, (using the -1):
> * you're not yet in pkg-php-pear, so I'd suggest putting yourself as
>   maintainer until then, as you did with php-mf2
> * the php dependency is just wrong, since 'php' is a metapackage with a
>   different versioning, etc.  probably using php5-common (>= 5.3.0) as
>   phpcomposer does it enough.
> * you build-depend on pkg-php-tools, but you use none of the helpers,
>   please drop the build-dep.
> * the copyright file say GPL-2+, but you point to the GPL-3 file under
>   /user/share/common-licenses, please point to the GPL-2 file instead
> * please remove line 17 on d/copyright, so you have only one blank line
>   between stanzas.
Fixed all the above bugs and uploaded to mentors. Please have a look at
the source files.

Attachment: signature.asc
Description: OpenPGP digital signature

Reply to: