Re: Introduce wrapper package of linuxbrew into Debian
Hi,
On Tue, 2015-08-25 at 16:29 +0000, Gianfranco Costamagna wrote:
> yes I got confused by this line
> usr/share/man/man7/linuxbrew-wrapper.7.gz usr/share/man/man7/linuxbrew.7.gz
with that symlink, both
man $PACKAGE_NAME i.e. man linuxbrew-wrapper
man $WRAPPER_NAME i.e. man linuxbrew
work.
> I was talking about "-x", not about "-r".
> Since the linuxbrew wasn't calling it automatically I tried to call it manually.
> But now that the bug is fixed there is no need anymore to use -x, so it is fine now.
Oops, that's a typo, in fact I mean the 'x' mode, not 'r'.
After all how can the ruby interpreter interprets a ruby script
ridiculously without 'r' mode ?
> not needed anymore, it was a bug, you fixed it, it is fine :D
However I see a new lintian warning saying script-without-x-mode
at the new queue. It doesn't matter but I think I'd better get
it fixed next time upload.
> the feeling was good, Built&Signed&Uploaded to new queue!
>
> thanks for your awesome contribution to Debian!
Thank you for sponsoring & checking ! :-)
> Now I have some final issues I would like to leave for a future upload:
> 1) I installed it and did a
>
> brew install cmake
>
> it installed brew correctly, but I had to run it again to properly start
> the cmake build.
>
> Maybe in the first run it shouldn't forget about the action requested?
> (not sure if a bug or a design feature)
Yes, the current wrapper script indeed drops the arguments
passed to itself, when installing linuxbrew.
(in fact pulling a git repo)
They can be merged into 1 step with this patch:
(merging them into 1 step may be better for those real first-time
linuxbrew users)
diff --git a/debian/bin/linuxbrew b/debian/bin/linuxbrew
index 458307c..de0bbb3 100755
--- a/debian/bin/linuxbrew
+++ b/debian/bin/linuxbrew
@@ -63,11 +63,13 @@ elif [ -d ${LINUXBREW_PREFIX} ]; then
false
elif [ -x ${BREW_INSTALL} ]; then
first_time_hint
- exec ${BREW_INSTALL}
+ ${BREW_INSTALL}
+ exec ${BREW_EXEC} $@
elif [ -r ${BREW_INSTALL} ]; then
if [ -x $(which ruby) ]; then
first_time_hint
ruby ${BREW_INSTALL}
+ exec ${BREW_EXEC} $@
else
printf "E: found no ruby interpreter to run linuxbrew installer.\n"
false
> 2) you might want to add a README.source or a get-orig-source target
> to explain where to grab the source code for it.
>
> e.g. I can understand the script comes from
> curl -fsSL https://raw.githubusercontent.com/Homebrew/linuxbrew/go/install
>
> but maybe making it under git revision, and adding a Debian pointer to it
> will allow other folks to see if updates are available or not.
The upstream install script is in linuxbrew.git branch: go
https://github.com/Homebrew/linuxbrew/blob/go/install
It has no version number, and upstream suggest that we keep
the data-based version number.
I have considered Debian pointers like the `watch` file,
however linuxbrew never releases,
(It's in the style of rolling update in terms of all linuxbrew Formulas)
So I just deleted watch file.
In order to decide that if there is a newer version of install script
available, there are 2 ways :
* track on commits of linuxbrew.git branch 'go'
https://github.com/Homebrew/linuxbrew/commits/go
But I found no related function in manpage of uscan.
* download that script and then diff,
if differs: new version is available
else: already updated.
Since that install script in relatively stable
(not yet changed since Apr 24)
I don't mind to manually update check and update it.
However I think automate the process will be better
for adopters. I'm about to add related things in d/rules
next time upload.
> thanks again for packaging it and for following my boring nitpicks :)
Also thanks again for pointing them out :-)
--
.''`. Lumin
: :' :
`. `'
`- 638B C75E C1E5 C589 067E 35DE 6264 5EB3 5F68 6A8A
Reply to: