Bug#795704: RFS: mlucas/14.1+dfsg-1 [ITP] -- program to perform Lucas-Lehmer test on a Mersenne number

[Gianfranco Costamagna <costamagnagianfranco@yahoo.it>]

Hi Alex,
let's review :)

d/changelog please set to unstable, and update the timestamp
d/rules: wl-asneeded is good if enable, does it introduce some problems?
are both autotools-dev and autoreconf needed?
usually the latter should superceed the former

d/rules: I personally do not like calling "bootstrap", specially when
the only thing needed there seems to be applying one patch and calling and generating
changelogs/manpages.

I would generate them with dh_installmanpages or the equivalent dh call.

d/patches/*: they seem to come from a git export-patch, are them already upstream?
so why don't just ask to release a new tarball?

carrying 30 patches might be a maintenance problem.

debian/repack seems not policy compliant (didn't check)
maybe get-orig-source.sh is better as a name
also source_package_build.bash

but I guess this might be a nitpick, since they are called by uscan
so the user/developer never need to call them directly.


d/watch what is the timestamp there?

oh well, seems that upstream in that way doesn't increase the version number when releasing
bad numbering is bad :)

let me know,

(I didn't try to build the package, and didn't check the copyrights)

cheers,

G.



d/copyright: expat seems "commented" (even if not a problem)
same for gpl





Il Venerdì 21 Agosto 2015 14:20, Alex Vong <alexvong1995@gmail.com> ha scritto:
Package: sponsorship-requests
Severity: wishlist

Hi mentors,

I am looking for a sponsor for my package "mlucas",

I have uploaded a new version of the package to fix issues pointed out
by Jakub Wilk,

please see previous message in the bug report to see what issues are fixed

I will now elaborate more on why this package is suitable for Debian,

feel free to skip it

__BEGIN_ELABORATION__

Great Internet Mersenne Prime Search (GIMPS) is a collaborative
project of volunteers who use freely available software to search for
Mersenne prime numbers (quote from Wikipedia). The most popular client
`mprime' was available in Debian Potato as the package `prime-net' as
shown in this post
<http://www.mersenneforum.org/showthread.php?t=7181>. However, it
appears the maintainer had lost interest in it because it was
classified as `non-free'. `mlucas' has been developed as an
alternative since 1996. While it is not as efficient as `mprime', it
is licensed under GPL-2+ and thus suitable to be included in `main'.
It has been used in the verification of various Mersenne primes,
including the 45th (found in 2008), 46th (found in 2009) and 48th
(found in 2013) found Mersenne prime. Therefore, the underlying
algorithm is believed to be reliable, thus suitable to be included in
Debian.

__END_ELABORATION__

* Package name    : mlucas
  Version         : 14.1+dfsg-1
  Upstream Author : Ernst W. Mayer <ewmayer@aol.com>
* URL             : http://hogranch.com/mayer/README.html
* License        : GPL-2+
  Section         : math

It builds those binary packages:

  mlucas     - program to perform Lucas-Lehmer test on a Mersenne number

To access further information about this package, please visit the
following URL:

http://mentors.debian.net/package/mlucas


Alternatively, one can download the package with dget using this command:

  dget -x http://mentors.debian.net/debian/pool/main/m/mlucas/mlucas_14.1+dfsg-1.dsc

Changes since the last upload:

  mlucas (14.1+dfsg-1) UNRELEASED; urgency=low

    * Initial release (Closes: #786656)

   -- Alex Vong <alexvong1995@gmail.com>  Sun, 02 Aug 2015 03:13:37 +0800

Cheers,
Alex