[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#795771: RFS: dblatex/0.3.7-1



control: owner -1 !

Hi Andreas,

let's review:
1) please use a machine-readable copyright file
http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
2) d/compat: please bump to 9
3) d/control: you might want to run wrap-and-sort to clean the formatting up,
to bump debhelper to >=9 and to remove some already satisfied in oldstable version constraints.
4) d/rules: please prepend comments in overrides with a "tab" instead of spaces
(vim is really showing them in a bad way)
5) d/rules:
I do not see the reason for get-orig-source target. if uscan works, what is the pourpose of it?
6) d/rules: examples should belong to dh_installexamples not to dh_installdocs (unless
I'm missing something)
7) d/rules: I would add something like "--buildsystem=pybuild" to the default dh call.
8) if the examples are the reason for the get-orig-source target, and if upstream ships them
in a different source tarball, please then consider a package split
9) d/rules: mv debian/dblatex/usr/share/doc/dblatex/xhtml debian/dblatex/usr/share/doc/dblatex/html

it is nice to current don't break existing installations, but I would instead create a symlink,
rather than breaking the new installations (assuming some users might have compiled the documentation
on their own.

man dh_link might be useful there


would you  mind fixing the above?


Reply to: