Hi Markus, On 2015-06-05 13:52, Markus Schade wrote: > New package for yadifa 2.1.0 is available > > http://mentors.debian.net/debian/pool/main/y/yadifa/yadifa_2.1.0-1.dsc > > It would be great if someone could sponsor this package. I think > the history of this bugreport proves that the package is well > maintained. And it is much better than upstream referencing my github > repo as the canonical way to get yadifa to run on Debian/Ubuntu. I just checked your package and I think that it is almost ready for upload. Here are just a few minor points: debian/copyright: - lintian complains about non-unique license specifications. Applying the pattern from Example #2 of [1] should resolve this issue. debian/control: - You can drop the version restriction for dpkg-dev. The version in oldstable (wheezy) is already higher. debian/changelog: - Please remove all entries except the newest one which documents the initial release. debian/yadifa.default debian/yadifa.service: - AFAIUI, when using systemd, the contents of /etc/default/yadifa will be ignored. This might be a problem for users switching from sysvinit to systemd later on. If they changed the default, eg by changing the location of the configuration file, this change will no longer be honored after the systemd switch. One way you can address this problem is by using EnvironmentFile in the service file. The cron package does it that way, for example. debian/rules: - I believe the "export DH_OPTIONS [...] to make magic work" can be dropped. I think this is a remnant from a time long past; I can't find any reference to this in recent documentation. dh(1), for example, makes no mention of this. Second opinions welcome... [1] https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#stand-alone-license-paragraph Regards, Christian
Attachment:
signature.asc
Description: OpenPGP digital signature