Bug#793171: RFS: git-lfs/0.5.2-1 [ITP]
Responses inline. In addition I updated the version to 0.5.4-2 at http://mentors.debian.net/package/git-lfs (dsc: http://mentors.debian.net/debian/pool/main/g/git-lfs/git-lfs_0.5.4-2.dsc)
Stephen
> On Jul 22, 2015, at 3:52 PM, Hugo Lefeuvre <hugo6390@fr33tux.org> wrote:
>
> Hi,
>
> Here is a quick review of your package.
>
> (1) debian/control:
> -------------------
>
> - Please, write a longer extended description.
Done
> - It isn't necessary to specify git "(>= 1.8.0)", Debian has
> squeeze -> 1:1.7.2.5-3;
> squeeze-backports -> 1:1.7.10.4-1~bpo60+1;
> wheezy -> 1:1.7.10.4-1+wheezy1;
> wheezy-backports -> 1:1.9.1-1~bpo70+1;
> wheezy-backports -> 1:1.9.1-1~bpo70+2;
> jessie-kfreebsd -> 1:2.1.4-2.1;
> jessie -> 1:2.1.4-2.1;
> stretch -> 1:2.1.4-2.1;
> sid -> 1:2.1.4-2.1;
> experimental -> 1:2.1.4+next.20141218-2;
> experimental -> 1:2.4.3+next.20150611-1;
> sid -> 1:2.4.6-1;
> experimental -> 1:2.5.0~rc2+next.20150720-1.
> - It isn't necessary to specify golang-go "(>= 1.3.0)", Debian has
> wheezy -> 2:1.0.2-1.1;
> wheezy-backports -> 2:1.3.3-1~bpo70+1;
> jessie -> 2:1.3.3-1;
> stretch -> 2:1.4.2-3;
> sid -> 2:1.4.2-3.
I included these in case one wanted to backport this to wheezy (which was particularly useful to me when building the package). Is that not considered good practice? If so I will remove.
> - Please, run 'wrap-and-sort -a’.
Done
> - Please, specify Vcs-Browser and Vcs-* fields if you are using a Vcs
> for your Debian work. If not, consider using one.
Moved source into github and added.
>
> (2) debian/copyright:
> ---------------------
>
> - You aren't mentioned in the copyright file. You should add a
> paragraph for debian/* that mentions you work.
Added
> - Since you aren't providing any upstream e-mail adress in the
> Copyright field, it might be a good idea to specify an
> Upstream-Contact field.
Makes sense. Added
>
> (3) debian/changelog:
> ---------------------
>
> - Please, use urgency=low.
Done
>
> (4) debian/watch:
> -----------------
>
> - Please, write a watch file.
Done
> - Optionally, it could be a good idea to ask git-lfs' upstream to
> provide signed releases.
I asked the git-lfs maintainer to sign releases in the future and he seemed willing.
>
> (5) debian/rules:
> -----------------
>
> - 'rm -f debian/debhelper.log' should be automatically done by dh_clean.
> Why are you specifying this rule ?
You are correct. I have removed it. I’m not quite sure why it ended up there, likely something I was testing but never removed.
> - Lintian reports 'P: hardening-no-fortify-functions'. If this warning
> is justified, you should fix it. Otherwise, this warning must be
> overriden with an informative comment.
Override added
>
> (6) debian/docs
> ---------------
>
> - Some additionnal documentation is provided in the source code (like
> README.md), you should consider integrating it in the package.
Extra docs are now integrated into the package
>
> (7) sourcecode
> --------------
>
> - codespell reports some spelling errors in the source code. You
> should consider fixing them:
>
> ./lfs/transfer_queue.go:81: occured ==> occurred
> ./lfs/transfer_queue.go:154: transfered ==> transferred
> ./vendor/_nuts/github.com/spf13/cobra/README.md:65: libary ==> library
> ./vendor/_nuts/github.com/ogier/pflag/bool_test.go:54: requred ==> required
All typos submitted upstream.
>
> Thanks for your work !
>
> Regards,
> Hugo
>
> --
> Hugo Lefeuvre (hugo6390) | www.hugo6390.org
> 4096/ ACB7 B67F 197F 9B32 1533 431C AC90 AC3E C524 065E
Reply to: