[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#781927: RFS: qemuctl/0.3.1-4 [ITA] -- control gui for qemu



Hi Antti,




>Not changed yet, but inquiry sent to 
>http://lists.alioth.debian.org/cgi-bin/mailman/private/pkg-qemu-devel/2015-August/006604.html
>so if they have good suggestions, then one more upload to mentors
>will be needed.


I can't/won't read, but ok, it is good as-is, let me know if you will need a new upload.

>> 6) d/watch file: you might want to use the Debian redirector instead of pointing directly to sf
>> https://qa.debian.org/cgi-bin/fakeupstream.cgi?upstream=sf/qemuctl
>
>Ok, didn't know such thing was in place. Qemuctl is not listed
>in re-director so adding it there would require another ticket into BTS.
>To avoid this hassle, I'm leaving the current URL because it is working 
>ok with uscan. 


Actually it is listed, but as said on irc, if the sf link is automatically translated by uscan
maybe it is better to leave it

[snip]
>dget -x http://mentors.debian.net/debian/pool/main/q/qemuctl/qemuctl_0.3.1-4.dsc


last two nitpicks and issues:

1) there is no need to call the files under debian directory
"qemuctl.manpages" as long as you have only one binary package "manpages" is good enough.

(note: I'm not asking to change that)


2) you might find useful to remove the "debian/dirs" file, because it should be
useless since you already have your install file.


3) the license of the package seems to be wrong:

accoding to licensecheck and manual checks I did, the files have a license
GPL-3+, not GPL-2+
(and thanks for promptly replying to the feedbacks)



please let me know how do you feel about the last three things,
and I'll do the final checks&upload.


cheers,

Gianfranco


Reply to: