Thanks again for another review Bas. On 02/04/15 19:59, Sebastiaan Couwenberg wrote:
I have fixed (I hope) all the other issues, but have one question before I finish. The package.json file also "requires" through. Should we leave this pristine so users know what upstream intended to be used (through), or also patch it to show what we used (through2)?You may want to consider extending Use_through2.patch to cover all files that use the through module, there are some tests that require it too. Since the test dependencies cannot be satisfied in Debian strictly required.
Cheers, Ross