Am Mittwoch, den 01.04.2015, 22:51 +0300 schrieb Antti Järvinen: back to the package: > Hmm, I could do something like introducing a build-time dependency to > imagemagick (I think I crafted the lower-resolution bitmaps with gimp by > hand) and try to do the format+size conversion tricks with that? The image topic is not solved yet, as written earlier: Take a look at xcftools -- xcf2png(1) seems to be the tool you want (not tried, though) d/changelog: remove the reference to experimental. (and please update the timestamp; hint: dch -r "") d/control: It is sufficient to depend on debhelper >9, (>9~ is not required.) d/copyright: We're almost there... The paragraph at line 37 is not yet right. If you have in a Files: section "License A or B or C" those are actually 3 licenses, which needs each of them its own paragraph. Continuing this abstraced example, you'd have: Files: ... License: A or B or C License A: <Grant + Text of A> License B: <Grant + Text of B> License C: <Grant + Text of B> One of them will be "LGPL-2.1-with-Nokia-Exception" For this, your d/copyright is incomplete: You have to quote the *complete* license text, namely the content of the LGPL_EXCEPTION.txt file in d/copyright; a reference to it is not enough. There a a few trailing whitespaces in the file d/rules: the second export line can go. Hardeing is enabled with compat level >=9. d/watch: It is best practice to use a more broad file extension regex: \.(?:zip|tgz|tbz|txz|(?:tar\.(?:gz|bz2|xz))) (refer to: https://wiki.debian.org/debian/watch#Common_mistakes) (But I do not know if if github offers something "better"(tm) than gz when releasing tarballs.) The git repositroy should also have a pristine-tar branch to keep the orig.tar.gz in the repository. gbp-importorig(1) could help you here, even if that is not the original intention of this command and might need cleanup e.g tags and brancheslater.) (see the pristine-tar option; you might need a temporary branches and tell it not to merge; you maybe also want to delete extra tags it creates..) This should to it, YMMV: git checkout master && git checkout -b tmp && git checkout debian && \ gbp import-orig --no-merge --pristine-tar --no-interactive \ --upstream-branch=tmp ../classified-ads_0.05.orig.tar.gz (of course you can also use pristine-tar(1) directly, but I'd play with gbp to see how gbp is doing it and the resulting pristine-tar-branch structure) Please check this if it is valid: $ cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not find or open any of the paths given.' [net/retrievalengine.cpp:113]: (error) Dereferencing 'connectCandidate' after it is deallocated / released (not required for the upload but on my wishlist:) -> You have a testsuite which may should be run at buildtime and at ci.debian.net -> In the source code you've mixed tabs and spaces... Maybe you can work towards a coherrent coding-style-guidline to ease reading of the code? -> configure your editor to remove trailing whitespaces :) -> check-all-the-things has also some input for you, eg. codespell is a little bit sad and there are warnings from flawfinder regarding potential unsafe use of the random number generator. -- tobi
Attachment:
signature.asc
Description: This is a digitally signed message part