* Dmitry Smirnov <onlyjob@debian.org> [150401 07:34]: > On Tue, 31 Mar 2015 19:35:12 Etienne Millon wrote: > > I am looking for a sponsor for my package "opentyrian" > > That is very nice. I was looking forward to see opentyrian in Debian for a > while. Thanks for packaging. Thanks for taking the time to look at this. > > I'm happy to hear your remarks about this package. > > First thing to improve is to add more DEP-3 [1] headers to patches. > [...] > If you did not forward patches yet I'd recommend to wait no further and > document progress as described. I refreshed this, forwarded two patches and picked the upstream version of one. > Also there are some remarks about packaging: > > * There should be versioned Depends on "game-data-packager" which > actually support "tyrian-data" (i.e. "tyrian-data | > game-data-packager (>= 40)"). Done. > * Package should install icon (there are some in "linux/icons). > Icon is referenced from installed .desktop file. I'm not too familiar with how icons work, so I've installed them as /usr/share/icons/hicolor/NxN/apps/opentyrian.png. Is that correct? > * Repository do not match package uploaded to Mentors. There are > differences in "control" (Standards-Version) and in README.Debian. Classic case of forgotten push. Fixed. > * Why not enable full hardening? > (e.g. "export DEB_BUILD_MAINT_OPTIONS = hardening=+all") Done! > * Re-distribution of pre-built binary "macosx/tyrian.icns" in > source archive may be a bit of concern. It's being removed in the next release: https://bitbucket.org/opentyrian/opentyrian/commits/e4346769d72374e51f34eecf45515b6df85d00c0 > * There is a comma "," which is not present in the original copyright > statement after copyright year in > ~~~~ > Files: ./src/video_scale_hqNx.c > Copyright: 2003, MaxSt ( maxst@hiend3d.com ) > ~~~~ > IMHO it should be just "2003", not "2003,". > Other than this "debian/copyright" looks good. Indeed, fixed that. I repushed and reuploaded the package. Thanks! -- Etienne Millon
Attachment:
signature.asc
Description: Digital signature