Am Samstag, den 28.02.2015, 12:16 +1100 schrieb Riley Baird: > > I am looking for a sponsor for my package "classified-ads" > > That's great! I'm not a DD, so I can't sponsor your package, but I've had a look at it, and here are some things that I've noticed: > > d/changelog: > -This file should only contain Debian-related changes. Upstream changes > > -You won't be able to upload to unstable at the moment, since it's frozen for jessie. You should change this to "experimental". actually, in this case unstable is fine -- That package is new, so it won't interfere with Jessie. However the problems reported by Antti below are valid, you should fix them, also please read https://wiki.debian.org/UpstreamGuide -- you definitly need to separate upstream source and debian packaging; don't ship a debian dir in the tarball. Please also check if you can relicense with the OpenSSL exception. I did not really take a deep look at the package (I prefer that you fix the below first, especially the licensing), but for those where things I saw when browsing it: package-description in debian/control is nothing-saying. Or is this programm only good if you need a new bike? See Policy 3.4 Another first-sight: icon.png? Somehow does not relate to my perceived use of the program Why have your source-files have the executeable bit set? d/docs is 0 bytes long. I'd also know where is the source of the icons? (in images/*)? The image in ui Lenin-reading-pravda is probably still under copyright protection at least in some countries. This would mean you can not distribute it. However, IANAL. (There are also some other png which copyright is unclear) Please also consider running wrap-and-sort -- for example this removes trailing whitespaces and sorts your deps. Why do you need to manually add dependencies to libraries in your binary package? > d/compat: > -Debhelper 7 is old. You should switch to 9. > > d/classified-ads.1: > -You should include this with the software, not just in Debian. > -You should get rid of the comments explaining what nroff is. > -You note that "Upon uninstall of the program, the datafile is left lingering around". You might want to ask someone else, but this seems like bad practice. Just remove that sentence. (We do not delete files from $HOME upon uninstall) > d/control: > -Priority should be "optional", not "extra". > -Either fill in the Vcs-* fields, or get rid of them. Remark: I'll only sponsor packages when the packaging is held in a repository. (That's not required by the Policy, but it is in my sponsoring policy) > -You've listed some dependencies twice: once in d/classified-ads.substvars, and once in d/control. > -The long description of your package has some spelling/grammatical errors and is a bit short. Perhaps you could take some of the information off your homepage and put it there? > > d/copyright: > -You should use DEP-5 copyright > > d/docs: > -If you don't have any docs, get rid of this file. Otherwise, put them in there. > > d/README.source: > *Delete this file if there is no reason to keep it. > > d/rules: > -You'll need to update this to dh9 syntax. See here for a guide: https://www.debian.org/doc/manuals/maint-guide/dreq.en.html#rules > > General: > -It's a good idea to keep Debian development and upstream development separate. Don't include the debian/ directory with your upstream tarballs. > -I don't think that Debian can legally distribute classified-ads, since Nokia has not made the OpenSSL exception. On the other hand, I'm not sure if the LGPL cancels this out. I'm going to ask debian-legal. > > Good luck getting your package into Debian, > > Riley Bairdhttp://mentors.debian.net/debian/pool/main/c/classified-ads/classified-ads_0.03-1.dsc (PS: Please configure your MTA to wrap your lines automatically) -- tobi
Attachment:
signature.asc
Description: This is a digitally signed message part