Re: Bug#777347: RFS: pidgin-gnome-keyring/2.0-1 [ITP] [RFP #714018] -- integrates pidgin (and libpurple) with the system keyring
On 9 February 2015 at 10:55, Michael Fladischer <michael@fladi.at> wrote:
> Hi Luca,
Hello Michael, thanks for taking the time to have a look!
> On 2015-02-07 16:45, luca.boccassi@gmail.com wrote:
>> I am looking for a sponsor for my package "pidgin-gnome-keyring"
>
> I'm not a DD yet, so I can't sponsor your package, but I did a review on
> what to improve to attract more potential sponsors:
>
> * Create a debian/watch file for use with `uscan` so automatic checks
> for newer upstream releases are possible.
Done.
> * The Vcs-* fields do not point to a repository that contains the
> packaging. Furthermore, the use of services like github is disputed for
> packaging in Debian. Maybe collab-maint on Alioth is a better place to
> keep your VCS, but that's up to you and your sponsor.
I changed the master branch, now it tracks the "debianised" version of
the repo so that the landing page and default branch have the
packaging bits. If the sponsor objects to GitHub I'll switch. Thanks
for pointing out Alioth, I'll be ready if needed. I picked GitHub
because the upstream code is there as well and it makes sending back
contributions easier.
> * You do not have to use overrides for dh_auto_install and
> dh_installdocs in debian/rules. Youc can use debian/<package>.install
> and debian/<package>.docs for a source package with multiple binary
> packages.
Took out the install override, but I couldn't find an alternative for
" dh_installdocs --link-doc" that will make the -dbg package symlink
the doc directory to the binary package. Any idea how to do it?
> * The PHONY target declaration is not really necessary.
Took it out.
> * Is the packaging (debian/*) really from Ali Ebrahim as described in
> debian/copyright or was it your work?
Good point, the original control file comes from Ali's Ubuntu
packages, but I changed it and added other files, so I added myself
under the debian/* copyright listing.
One more change I did, I added "export DEB_BUILD_MAINT_OPTIONS =
hardening=+all" to the debian/rules file since by default "Immediate
binding" is not turned on. A new upload with the changes is on
mentors.
Final question, the changelog lists the package as "UNRELEASED", I
think it's right since it's never been in any Debian distro, but on
mentors it's raised as a red flag, any idea if I should change it?
Thank you very much for the tips, I really appreciate them!
Kind regards,
Luca Boccassi
Reply to: