disclaimer: I did not look at the package at all.
On Thu, Dec 24, 2015 at 09:37:31PM +0000, Iain R. Learmonth wrote:
> export V = 1
>
> I'm not sure what $V does. Is this really necessary for the release in the
> Debian archive?
Some people (me, for instance) like to have the build as verbose as
possible. locally I have DH_VERBOSE exported in my build env.
For this debhelper started passing a --disable-silent-rules to
autoconf and setting something else for other build systems, for example.
I'd love to see such common variables exported too, and ISTR there is a
bug for something like this.
> dh $@ --parallel
>
> Unless you have a good reason for the --parallel, please remove this. If it
> turns out later that the Debian build systems prefer this option, it would
> become a default.
This is going to be the default for debhelper compat 10. I tend to
force --parallel for my packages when the build takes more than 10
minutes otherwise and in my build env I have
DEB_BUILD_OPTIONS=parallel=4, since that way I have a huge performance
boost. Also this is nice for buildds (not only buildd.d.o, I'm also
talking about the ones rebuilding the archive, like rb.d.n, where the
throughput is kinda important), so they can waste less time on your
package and use better their CPU.
> As I said above, I prefer defaults be used whenever possible.
Your call :)
I'm just precising some bits.
This kind of stuff is really in the YMMV / YKINMKBYKIOK field :D
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: http://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature