Bug#808441: RFS: rfcdiff/1.42-1 ITP
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Hi Mattia!
Thank you very much for your review and also for introducing me
diffoscope.
On 12/20/2015 03:18 PM, Mattia Rizzolo wrote:
>
> review:
>
> trailing whitespaces: + debian/control:15 + debian/rules:3
Applied forgotten wrap-and-sort
>
> there is really no need to do that useless
> override_dh_auto_install, just empty that target in d/rules, and
> write 'rfcdiff' in debian/rfcdiff.install
>
> Makefile contains an 'include ../Makefile.common', while the file
> is in the same directory, guess it needs fixing? once done so the
> override_dh_auto_test and override_dh_auto_install can be removed
> entirely. This is a problem for upstream, please forward the
> issue.
>
The makefile seems to be for internal development use only. Also
Fedora is working around that faulty makefile.
https://kojipkgs.fedoraproject.org//packages/rfcdiff/1.41/7.el7/src/rfcd
iff-1.41-7.el7.src.rpm
I reported it to upstream, hopefully he will rework it.
Therefore I would like to keep the current version until upstream
comes up with a fixed version, with proper test and install targets
(including DESTDIR and PREFIX variables).
> stuff check-all-the-things tells me:
>
> $ cme check dpkg Warning in 'control binary:rfcdiff Depends:2'
> value 'diffutils': unnecessary unversioned dependency on essential
> package: diffutils
>
Thanks for the hint.
> $ codespell --quiet-level=3 ./changelog:178: refering ==>
> referring
Added a patch and forwareded it.
>
> $ licensecheck --check=. --recursive --copyright . | grep -F 'with
> incorrect FSF address' ./copyright: GPL (v2 or later) (with
> incorrect FSF address)
>
Added a patch and forwareded it.
> please forward the last 2 to upstream.
>
>
> The rest looks good, if you fix this few bits I'll upload it.
>
I re-uploaded a modified verion to mentors.
Thanks for taking the time.
Greetings Peter
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQIcBAEBCgAGBQJWdzAnAAoJED/ImGelQYVW0fUP/isgWAQFI6VH8gbDRVY1DxKU
xJCvpVvEu0u1SWcZzGcEwHqe8QUgE1uZWLG4VLziAy+dKYakt5yx2dXD1fKQ7pEO
SljOv0JLZpsR0JQowkfQdLJeHWyROUY6lCEEPtwtERa3KpNzgDoEsbq3gRO0oeQn
XdTLXPqRYhMqa+q2X5Rf+bRx0shqzwB3sJaw/1naCw3ehKifNbcJL1TwbeSegDJr
INLzLzdmjldfC0/No1Mbs44DeBliE3xiOVaETkjGWzf34q4BQ9lrms/qt00aqaLT
WxIluAWslmDwNluM65TMd5+lJbq9BQo3Akxh82RQf0KVu+7nXMWosP/+Nzj31AgM
y6ZhL4VZS0xjqI/h8vU/uwk6JxYkwPIThirI9sCjLQDvQ8iKBixxLNCCdk38FdUN
q3H3d/oDLkjNhacy26b5do8oBavjegRTAUVo1rHNAmJyxQ5OJ+7GEp7Q5PEkQh3P
KH0KvQqjM8wF4vIVjQMtPc+oXIhhe4ayLDsJMFppl4nfCJdVQeZzpi4k5xOKsi+1
6b+aRz4YXeifusvx8z6sErGMVDpf7vwfH6qVnUPhbucY3ZLnDm41L53UcBJzKhXS
C6tKEbh38l69+c8Zz44nd/TYmlXKyg7Mg8oYxRY3H70qPg5wNYznF1anZp1pP17s
23RCVXkvh+RP8JgEK7Og
=DTKx
-----END PGP SIGNATURE-----
Reply to: