[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#807743: RFS: filters/2.55-1 [ITA] - collection of filters, including B1FF and the Swedish Chef



Hello,

Thanks for the feedback. I'll send patches to upstream and ask him to
(officially) release 2.55 with these changes.

Gianfranco Costamagna <locutusofborg@debian.org> writes:

> $ codespell --quiet-level=3
> ./ken.l:199: anual  ==> annual
> ./jethro.l:172: councellor  ==> councillor, counselor, councilor
> ./chef:36: occurence  ==> occurrence
> ./filters.6:78: possibile  ==> possible
> ./scottish:21: noth  ==> north
> ./nyc.l:23: ther  ==> there, their, the
> ./nyc.l:31: wanna  ==> want to  | disabled because one might want to
> allow informal pronunciation
> ./newspeak.l:23: unchangable  ==> unchangeable
> ./newspeak.l:353: Miscelaneous  ==> Miscellaneous
> ./newspeak.l:401: alse  ==> else
> ./debian/changelog:312: nto  ==> not  | disable due to \n

Most of these were false positives, but I've fixed the few real ones.

> duck
> E: debian/control: Vcs-Browser: https://git.ieval.ro/?p=filters.git:
> ERROR (Certainty:certain)
>    Curl:0 HTTP:503 No error

This was a real 503, as the server was overloaded at that moment.
Working fine now.

> cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not find
> or open any of the paths given.'
> [scramble.c:175]: (error) Memory leak: word
> [scramble.c:180]: (error) Common realloc mistake: 'word' nulled but
> not freed upon failure

Fixed.

> perlcritic -1 . 2>&1 | grep -vF 'No perl files were found.'
>
> [lots]

This package is a collection of (mostly) very old scripts. I don't think
it is reasonable to expect them to conform to perlcritic, much less
perlcritic -1.

I'd be in favour of fixing some of the warnings from a script if I was
fixing a bug in it, but otherwise I believe there is no reason to modify
the scripts.
-- 
Marius Gavrilescu

Attachment: signature.asc
Description: PGP signature


Reply to: