Ciao Gianfranco,
first many thanks for your review.
Am Donnerstag, den 19.11.2015, 17:18 +0000 schrieb Gianfranco
Costamagna:
> Control: owner -1 !
> Control: tags -1 moreinfo
>
> Hi
>
>
> check-all-the-things:
> codespell --quiet-level=3
>
> cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not find
> or open any of the paths given.'
> [src/bitz/manager.cpp:212]: (error) Exception thrown in throw()
> function.
>
I think this is ok. But I write a mail to the upstream author.
>
> duck
> E: debian/control: Vcs-Browser:
> http://anonscm.debian.org/cgit/collab-maint/bitzserver.git: ERROR
> (Certainty:certain)
> Curl:0 HTTP:404 No error
upps... rewrite to .../bitz-server.git
>
>
> pep8 --ignore W191 .
>
>
> pyflakes3 .
> ./test/icap-client.py:17:27: invalid syntax
> print "----- OPTIONS -----"
> ^
> ./modules/modpy/modules/modpy.py:9:22: invalid syntax
> print "init() called";
> ^
>
Add a patch to make the code for fit python2 & python3
(d/p/0100-python_print.patch)
>
> and now the review:
>
> 1) priority maybe optional?
> https://www.debian.org/doc/debian-policy/ch-archive.html#s-priorities
done
> 2) bitz-server.install
>
> usr/share/man/man* <-- they belong to dh_installman
move to bitz-server.manpages
> 3) I would avoid to play with systemd scripts because of systemd bugs
> (I think they are in dh-systemd the problems, right?)
I don't kown. But I have remove the postrm script.
> 4) libcap0.install, please do not install .la files (they should be
> forbidden in debian IIRC and useless)
done
> 5) symbols:
>
> pease use c++filt
> sed 's/ \(_.*\) \(.*\)/ (c++)"\1" \2/' old | c++filt > new.symbols
>
also done
>
> the other stuff looks good to me
>
>
> (nitpick: the GPL3 license has incorrect FSF address)
>
mmh. On the FSF homepage the GPL-license are links to gnu.org. Shoult I
change them to fsf.org?
Build with pdebuild and sbuild are ok.
Lintian has only one pedantic warning.
Piuparts fails with "ERROR: FAIL: Package purging left files on
system:" from the systemd files.
Package is uploaded to mentors[1].
> cheers,
>
> G.
>
CU
Jörg
[1] http://mentors.debian.net/debian/pool/main/b/bitz-server/bitz-server_0.1.6-1.dsc
--
New:
GPG Fingerprint: 63E0 075F C8D4 3ABB 35AB 30EE 09F8 9F3C 8CA1 D25D
GPG key (long) : 09F89F3C8CA1D25D
GPG Key : 8CA1D25D
CAcert Key S/N : 0E:D4:56
Old pgp Key: BE581B6E (revoked since 2014-12-31).
Jörg Frings-Fürst
D-54526 Niederkail
Threema: SYR8SJXB
IRC: j_f-f@freenode.net
j_f-f@oftc.net
My wish list:
- Please send me a picture from the nature at your home.
Attachment:
signature.asc
Description: This is a digitally signed message part