Bug#803935: RFS [update]: pynac/0.5.0-1 -- Engine for symbolic geometric calculus for Python
Control: owner -1 !
Control: tags -1 moreinfo
Hi, many copyrights missing:
e.g.
ginac/infoflagbase.*
ginac/assume.* * Author: Ralf Stephan <ralf@ark.in-berlin.de>
something is missing from changelog:
libgmp-dev
change of copyright website
pre-depends dropped, section changed, shlibs dropped
(probably not everything is worth a changelog line, but some is)
override_dh_auto_install:
$(MAKE) DESTDIR=$(CURDIR)/debian/tmp install
rm -f debian/tmp/usr/lib/$(DEB_HOST_MULTIARCH)/*.la
I guess this can be changed in
override_dh_auto_install:
dh_auto_install
rm -f debian/tmp/usr/lib/$(DEB_HOST_MULTIARCH)/*.la
I see
-DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH)
removed,
but you still use it
rm -f debian/tmp/usr/lib/$(DEB_HOST_MULTIARCH)/*.la
(please consider a find -delete instead, because no .la file is needed on Debian)
copyright years might be updated.
check-all-the-things output:
codespell --quiet-level=3
(some stuff)
cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not find or open any of the paths given.'
(some stuff)
the other stuff looks good.
(there is no need I guess to patch the codespell and cppcheck issues, but I would appreciate an upstream report)
cheers,
G.
Reply to: