Bug#803620: RFS: afl-cov/0.3-1 [ITP] -- code coverage for afl
Thanks for picking this up!
On 01.11.2015 10:06, Gianfranco Costamagna wrote:
> quick review:
> 1) debian/patches/correct-fsf-address...
> well, I usually don't ask to change the address but to forward a patch upstream instead.
>
> Doing both is for sure really nice
... in the case some day somebody really writes a letter requesting a copy of the license :-)
> 2) you changed to subprocess32, this is nice, but can you please provide a rationale for it?
>
> better subprocess handling? why you didn't forward the patch upstream?
> I'm asking because such Debian delta usually might introduce downstream problems :)
The patch header is a little sparsely, I've added some info.
I don't wanted to add this change to the other things in the pull request stack on
Github not to overload it, but I've now posted an issue on this (Forwarded updated).
> 3) and now the important part, the reason for the moreinfo tag:
>
> are you sure about the license?
>
> I am not :p
... aaaah yes. Little pitfall: "or (at your option) any later version"! :-)
Mentors upload is updated, debdiff attached.
Best,
Daniel
--
4096R/DF5182C8
46CB 1CA8 9EA3 B743 7676 1DB9 15E0 9AF4 DF51 82C8
LPI certified Linux admin (LPI000329859 64mz6f7kt4)
http://www.danielstender.com/blog/
diff -Nru afl-cov-0.3/debian/copyright afl-cov-0.3/debian/copyright
--- afl-cov-0.3/debian/copyright 2015-10-31 22:17:17.000000000 +0100
+++ afl-cov-0.3/debian/copyright 2015-11-01 11:35:35.000000000 +0100
@@ -5,21 +5,22 @@
Files: *
Copyright: 2015 Michael Rash <mbr@cipherdyne.org>
-License: GPL-2
+License: GPL-2+
Files: debian/*
Copyright: 2015 Daniel Stender <debian@danielstender.com>
-License: GPL-2
+License: GPL-2+
-License: GPL-2
- This package is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License as published by
- the Free Software Foundation; version 2 dated June, 1991.
+License: GPL-2+
+ This program is free software; you can redistribute it and/or
+ modify it under the terms of the GNU General Public License
+ as published by the Free Software Foundation; either version 2
+ of the License, or (at your option) any later version.
.
- This package is distributed in the hope that it will be useful, but
- WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- General Public License for more details.
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
.
On Debian systems, the complete text of the GNU General Public License
- version 2 can be found in the /usr/share/common-licenses/GPL-2 file.
\ No newline at end of file
+ version 2 can be found in the /usr/share/common-licenses/GPL-2 file.
diff -Nru afl-cov-0.3/debian/patches/use-subprocess32.patch afl-cov-0.3/debian/patches/use-subprocess32.patch
--- afl-cov-0.3/debian/patches/use-subprocess32.patch 2015-10-31 22:32:28.000000000 +0100
+++ afl-cov-0.3/debian/patches/use-subprocess32.patch 2015-11-01 11:20:33.000000000 +0100
@@ -1,6 +1,8 @@
Description: use subprocess32 instead of subprocess
+ For thread safety, it's highly recommended to replace the Python 2
+ stdlib subprocess module on POSIX systems.
Author: Daniel Stender <debian@danielstender.com>
-Forwarded: no
+Forwarded: https://github.com/mrash/afl-cov/issues/13/
--- a/afl-cov
+++ b/afl-cov
Reply to: