[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#802848: RFS: gnome-twitch/0.1.0-1 [ITP]



Hi Tim,


>Hmm, I'm not really sure what you mean with that, but alright.


well, I started packaging in 2013 and I didn't provide good packages on the first tries.
(actually I'm still doing packaging mistakes)

You seem to be a better packager than me, and you told you are on your first packaging experience...
this is awesome :)

>Ok, that explains why the man page said I could install directly into
>debian/package if I only build one binary package.


exactly
>That makes sense, I did that now. Turns out this doesn't add much
>overhead, since the .install file is just a one-liner using a wildcard
>(at least as long as there is just one binary package).
>The new version is now uploaded to mentors.


as said before, if you don't like the solution feel free to revert the change, I'm fine
with both solutions, as long as you are aware of pro/cons of both.

now another little issue:
../print_git_version.sh: 3: [: unexpected operator


building in a clean environment shows this error.
basically there is no git command, so use your best solution to patch the source
or add git to build-dependencies (or just discard the issue if you think this is 

a non-issue)


$ find -type f -iname '*.desktop' -exec desktop-file-validate {} \;
./data/com.gnome-twitch.app.desktop: error: value "GTK;GNOME;AudioVideo;Player;Video" for string list key "Categories" in group "Desktop Entry" does not have a semicolon (';') as trailing character


the other stuff looks good to me.

cheers,

G.


Reply to: