[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#793162: flask-flatpages



Hi, some final nitpicks:

1) please avoid double "\n" when possible.

e.g. copyright lines 9-10

rules lines 6-7


(control file, various parts)
and now something more important:
2) override_dh_auto_clean:
    dh_auto_clean

this is absolutely useless :)

3) "cd docs && make html"

please consider running

$(MAKE) -C docs html

(sorry for pointing you to pyqtgraph that doesn't do this :) )


4)
X-Python-Version: >= 2.6
X-Python-Version3: 3.3


are you sure about the second line?

5)
python-all (>= 2.6.6-3~)

this is satisfied even in old old stable, please remove the version constraint

(you might consider removing version constraints also for yaml and flask, but it is up to you)

6) "I possible-documentation-but-no-doc-base-registration"
you didn't add a doc-base file

7) 
X privacy-breach-generic

usr/share/doc/python-flask-flatpages-doc/html/genindex.html (http://s3.amazonaws.com/github/ribbons/forkme_right_darkblue_121621.png)
usr/share/doc/python-flask-flatpages-doc/html/index.html (http://s3.amazonaws.com/github/ribbons/forkme_right_darkblue_121621.png)
usr/share/doc/python-flask-flatpages-doc/html/py-modindex.html (http://s3.amazonaws.com/github/ribbons/forkme_right_darkblue_121621.png)
usr/share/doc/python-flask-flatpages-doc/html/search.html (http://s3.amazonaws.com/github/ribbons/forkme_right_darkblue_121621.png)

maybe you can consider patching the sources to remove the affected lines.


cheers,

G.


Reply to: