Re: RFS: partimage/0.6.8-4 [QA]

[Gianfranco Costamagna <costamagnagianfranco@yahoo.it>]

Hi Daniel!

First thanks for doing the work!

I have some questions for you:
1) two bugs have patches, why didn't you include/drop tags for them?
2) you switched to autoreconf instead of autotools, this is fine, but please consider dropping autotools-dev from build-dependencies
3) please set yourself as maintainer if you intend start maintaining it
4) how do you feel about updating the package to the latest upstream version?
5) you dropped something from rules:
-DEB_CONFIGURE_EXTRA_FLAGS := --with-log-dir=/var/log/partimage \
-                             --with-debug-level=1 \
-                             --enable-pam

are them just the default so you don't need to specify them anymore?

6) the copyright file has some licenses I don't like too much.

can you please update them by looking to some other Debian packages on codesearch.debian.net?
http://codesearch.debian.net/results/License%3A%20GPL-2%2B%20path%3A%2Fcopyright%24/page_0

e.g. dpkg package has a good GPL-2+ license

while the GFDL-1.1+ license is problematic when there is the "invariant" part.

https://wiki.debian.org/DFSGLicenses
https://www.debian.org/vote/2006/vote_001

please check if it is the case.

Cheers,

G.

(note: I didn't do a full review, so as soon as the above is addressed/fixed/answered I'll do another trip)




Il Venerdì 23 Ottobre 2015 14:27, Daniel Lenharo de Souza <daniel@lenharo.eti.br> ha scritto:
  Dear mentors,

  The partimage package is orphaned and realized some QA tasks on it.

  I am looking for a sponsor for my package "partimage"

* Package name    : partimage
   Version         : 0.6.8-4
   Upstream Author : [fill in name and email of upstream]
* URL             : [fill in URL of upstreams web site]
* License         : [fill in]
   Section         : admin

  It builds those binary packages:

partimage  - backup partitions into a compressed image file
partimage-server - server to use partimage across a network

  To access further information about this package, please visit the
following
URL:

  http://mentors.debian.net/package/partimage


  Alternatively, one can download the package with dget using this command:

    dget -x
http://mentors.debian.net/debian/pool/main/p/partimage/partimage_0.6.8-4.dsc



  Changes since the last upload:

  * QA upload.
  * Updated the DH level from 8 to 9.
  * Bumped Standards-Version to 3.9.6.
  * debian/watch: Created.
  * debian/rules: Changed to use autools.
  * debian/control:
      - Removed dependency: cdbs.
      - Included dependency: dh_autoreconf.
  * debian/partimage-server.docs: Included files.
      - BUGS.
      - AUTHORS.
      - THANKS.
      - README.
  * debian/patches/01-openssl.patch: Header updated.
  * debian/patches/02-security.patch: Header updated.
  * debian/*: removed empty endlines.

There are more things to be done to make it better.
The intention was not reset the lintians messages.


  Regards,
   Daniel Lenharo de Souza