[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#801838: RFS: node-es5-shim/4.1.14+dfsg-1 [ITP]



Hi, Built&Signed&Uploaded, 

thanks for your contribution to Debian!





Il Giovedì 15 Ottobre 2015 21:51, Julien Puydt <julien.puydt@laposte.net> ha scritto:



Hi,

Le jeudi 15 oct. 2015 à 08:16:24 (+0000), Gianfranco Costamagna a écrit :
> Control: owner -1 !
> Control: tags -1 moreinfo
> 
> as said on irc:
> 
> 1) rules:
> 
> override_dh_auto_test: please add a comment on the above line regarding the reason for
> disabling the testsuite (requires internet connection or similar)
> 
> 2) rules:
> override_dh_auto_install:
>            dh_install
> 
> what? ^^^
> 
> 3) add a README.source explaining the reason for having a dfsg repackage (even if copyright files-excluded is clear)
> 
> 4) you install both es5-*.js and es5-*.min.js, are them needed both?
> 
> the other stuff looks good to me
>

I reworked it according to irc discussions ; the new upload is here (no more +dfsg):
http://mentors.debian.net/debian/pool/main/n/node-es5-shim/node-es5-shim_4.1.14-1.dsc 


Thanks,

Snark on #debian-js


Reply to: