Bug#790412: RFS: circus/0.12.0-1
Control: owner -1 !
Hi David
quick review:
1) control: runtime dependencies:
please let python:Depends to its job
I see in setup.py
install_requires = ['iowait', 'psutil', 'pyzmq>=13.1.0', 'tornado>=3.0']
(also: why some dependencies are not listed here?)
2) rules/control: please consider using python3
3) rules:
- why you remove examples from build?
- "make -C docs" I would use $(MAKE) -C docs
the other stuff looks good, but I didn't check carefully yet :)
(and I didn't try a build&run)
cheers,
G.
Reply to: