[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#790104: RFS: lightdm-gtk-greeter-settings/1.2.0-1 [ITP]



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
 
On 11/10/2015 2:37 AM, Christian Kastner wrote:
> On 2015-10-11 07:54, James Lu wrote:
>>> d/copyright:
>>>  - The license appears to be GPL-3, not GPL-3+ (at least in the handful
>>>    of files I checked). This also requires correction of the free-
>>>    standing license block (the last paragraph)
>>
>> I see. Ubuntu's packaging wrote the license as GPL-3+ for both the
>> packaging and the source, but I guess the license of the individual
>> files must prevail here. Fixed.
>
> Hm, I just realized that I overlooked something here, namely the license
> of the packaging that came from Ubuntu :-/
>
> that makes things a bit more complicated, because:
> * It is clear that upstream wanted GPL-3 for the upstream source
> * It is clear that Ubuntu's packager wanted GPL-3+ for the
> packaging, even if this motive was inspired by the erroneous
> assumption of the GPL-3+ for the upstream source (asking the
> packager directly might resolve that)
>
> IOW, my initial advice was wrong. You need to keep GPL-3+ for the
> packaging, and add GPL-3 for the upstream source.
>
> Sorry about the mixup!

That's what I did here (forgot to mention it more clearly). The upstream
source (*) is set to GPL-3 and the Ubuntu packaging + my changes (the
debian/ folder) is GPL-3+.

>
>>>  - There's a formatting issue in the free-standing license text (line
>>>    27 is not indented)
>>
>> I'm not sure what this means. Is it supposed to be indented to the width
>> of "X-Comment: "? That's what I did.
>
> Oh, I see what you meant to do now -- it wasn't lacking indentation, it
> was beginning a new field.
>
> However, in that case, the field's name is just "Comment" [1], without
> the "X-" prefix.
>
> [1]
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#stand-alone-license-paragraph
>
> Regards,
> Christian
>
Done. I'll fix the other email too.

Best,
James
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
 
iQIcBAEBCAAGBQJWGpomAAoJEC7D9g3nHAudhHgQAKHfBGL6+thgDlU6egJVxFu8
PjGRHafdRRyyupFkxbLlTU3u4BIzPn68Mcl9+dqlUVOMiDI0YCnzBAqnH22mRAt8
VbUxt/SAwzFKb0eZOsIQcYNXkaxhkrXudqs0sPi6+HyJ++oXQLKZBfMpp+l/ndnP
r5einjxeSEKkK2uXwOoh+O4lUgubhS3cUGnIfhufaN1btl5MvBybwgOCM1q5OQ87
fn1DvqvlaAbkjvMkp7BAjDdAwMpASgcHnPW97FomO3JbdCrXzYSk0n85alLtv7xa
mEF6F7woKtwwzmj6FYTXk7F8lqV0ccMktbiTUsb0lzyGRJWeryAH9U2sptLAizm5
G46lNHLFrmnTWZ7cjHuJ/kbFRIKbJhpXSUV+oCivCfVrxnOHY1qnt2Mqb8f339Dc
Z/sXLaWqW1KSxGi3uhtGtL7F5a4xy/ME+6u7EoIAwC/KoBgbRxaNIbb8RCXx7s/S
hdvnnBAhM9hQl6hqeoR28uxy/a0BDDNAA/K+NtrjdJrmHDM/kAIkthqIhgSfUbF3
HeH20EyCEmd8yMKhXL/AllmdkWm8hZFwVUB2FdXvJqYtCsSdGJvCVpqe/6/gtVLb
U54fr8gueBSS5pDCrbIbgYwN8YePENlckxe6PVe0xPCBkWQoSnTNisszf3Zbn1gI
TUKysudqNq8OrP1riYoo
=C+Q6
-----END PGP SIGNATURE-----


Reply to: