Bug#801197: RFS: smplayer-themes/1:15.6.0-1

[Mateusz Łukasik <mati75@linuxmint.pl>]

On 07.10.2015 15:00 +0200, Gianfranco Costamagna wrote:
> control: owner -1 !
> control: tags -1 moreinfo
>
> Hi,

Hello,

> 1) d/changelog:
> smplayer-themes (1:14.9.0-1) unstable; urgency=medium
>
> +  [ Alessio Treglia ]
> +  * Upload to unstable.
> +
> +  [ Mateusz Łukasik ]
> * New upstream release.
> * debian/control:
> - Add myself to uploaders.
>
>
> this isn't what has been uploaded in the previous release.
> https://tracker.debian.org/news/575394

I add this to present changelog.

> 2) please do not override public domain lintian warning:
> http://codesearch.debian.net/results/public-domain/page_0
> http://codesearch.debian.net/results/Public-Domain/page_0
>
> instead try to fix it.

Fixed.

> bonus point)
>
> ./debian/rules:	dh_auto_install -- PREFIX=/usr
>
>
> I would like to avoid "PREFIX" set in rules file.
>
> are you sure it is needed?
>
> (note: I didn't test the above, but this is an issue that might be good to forward upstream)

When it is dropped build return this:

dh_usrlocal: 
debian/smplayer-themes/usr/local/share/smplayer/themes/Oxygen-KDE/Oxygen-KDE.rcc 
is not a directory
dh_usrlocal: 
debian/smplayer-themes/usr/local/share/smplayer/themes/Oxygen-KDE/README.txt 
is not a directory
rmdir: failed to remove 
'debian/smplayer-themes/usr/local/share/smplayer/themes/Oxygen-KDE': 
Directory not empty
dh_usrlocal: rmdir 
debian/smplayer-themes/usr/local/share/smplayer/themes/Oxygen-KDE 
returned exit code 1
debian/rules:6: recipe for target 'binary' failed

Makefile used /usr/local as default.

> (I also didn't try to build, I'll do as soon as the above is fixed)
>
> cheers,
>
> G.


Mateusz