Bug#745126: RFS: passwordsafe/0.95.1+dfsg-1
Thanks so much for all the feedback.
On Wed, Sep 23, 2015 at 11:03:01PM +0200, Tobias Frost wrote:
>
> - d/source/options: Why do you have the option diff-ignore?
Issues with the translation files - When the .mo files get generated, the .po
files get updated with a new timestamp, causing repeat builds from the same
source to fail the dpkg-source check. I did quite a bit of searching on how to
deal with it, but that was the only solution I found. Is there a better way to
handle it?
> - d/patches are marked as Forwarded: no and not-needed. Are they really
> not upstreamable?
The pixmap patch I could forward, but with the menu/.desktop change, I think I
can go ahead and remove it since the pixmap won't be needed. (desktop can use
the existing png, whereas menu couldn't)
The path patch is for compliance with the FHS, so I think it's Debian-specific
since not all distributions follow the FHS.
The gcc5 fix is cherry picked from an upstream commit, so there's no need to
forward it. When the next upstream release is made for Linux, I'll be able to
remove it.
> - please use wrap-and-sort; this will also remove those trailing
> whitespaces I love to nitpick about...
Done.
>
> - Well, README.LINUX does not really have information for the user
> beside it's beta, so I'd not install it but explain in the package
> description that not all features are implemented
Done.
>
> - I would not install both the html and txt version of
> docs/ReleaseNotes, they have identical content. Also, this seems to be
> the project's changelog, so it should be installed with
> dh_installchangelog and not via dh_installdocs. Therefore it should
> also not be registered using doc-base
Done. Note, I created an override for dh_installchangelogs to keep (symlink)
the original name, since it's referred to by name in README.txt.
>
> - d/menu should be depreciated in favour of .desktop files, so remove
> this file. See also #741573
Done. That was an interesting read, thanks :-)
>
> - the chm file you refer in your source override -- I guess it is not
> built at build time. We need to build everything from source... Can you
> simply remove it?
Upon further inspection, I don't think we actually need it. Removed via
d/copyright Files-Excluded
> That's how far I come... Will continue as soon as possible
Really appreciated, thanks!
Reply to: