Bug#787328: RFS: mpd-sima/0.13.1-1

[Gianfranco Costamagna <costamagnagianfranco@yahoo.it>]

Control: owner -1 !

Hi Geoff,

lets review:

1) you dropped 0.10.0-2 entry from changelog
2) entry 0.10.0-1 is targeted wrongly
3) bump compat level not mentioned in changelog
4) according to setup.py
install_requires=['python-musicpd>=0.4.1', 'requests>= 2.0.2'],

so I guess there is no need to specify them to runtime dependencies
(please check)

5) please mention copyright updates
6) mpd-sima.default
"+## NOTA BENE:"
this seems to be italian, please use english

7)
+## only works with SysV init
+## With systemd init: "touch /etc/mpd-sima_not_to_be_run" to prevent mpd-sima from being started


well, can't you use some systemd facilities to do the same?

http://www.freedesktop.org/software/systemd/man/systemd.unit.html
http://www.freedesktop.org/software/systemd/man/systemd.service.html

(or make systemv script behave in the same way)


the other stuff looks good to me



(note, some of them might be not issues or just nitpicks, feel free to tell me so if
you think they are good that way)

cheers,

G.


Il Sabato 12 Settembre 2015 16:21, Geoff <efrim@azylum.org> ha scritto:
Hi

I'm looking for a review|sponsor of my package (already in debian).
I'm posting on debian-python as well if someone wants to have a look at
the python packaging :)

My previous sponsor is not responding, so if somebody is willing to
upload the package, you're welcome to do so as well.

Thanks
Geoff

Le 31/05/2015 16:03, Geoff a écrit :
> Package: sponsorship-requests
> Severity: normal
> 
> Dear mentors,
> 
> I am looking for a sponsor for my package "mpd-sima":
> 
>  * Package name    : mpd-sima
>    Version         : 0.13.1-1
>    Upstream Author : Jack Kaliko <kaliko@azylum.org>
>  * URL             : http://kaliko.me/code/mpd-sima/
>  * License         : GPL3+
>    Section         : sound
> 
> It builds those binary packages:
> 
>    mpd-sima   - Automagically add titles to MPD playlist
> 
> To access further information about this package, please visit the
> following URL:
> 
>  http://mentors.debian.net/package/mpd-sima
> 
> Alternatively, one can download the package with dget using this command:
> 
>   dget -x
> http://mentors.debian.net/debian/pool/main/m/mpd-sima/mpd-sima_0.13.1-1.dsc
> 
> 
> Changes since the last upload:
> 
>   * python3 convertion, major package refactoring
>   * Migrate to dh-python
>   * Bumped Standards-Version to 3.9.6
>   * Add pgpsigurlmangle for uscan
>   * Depends on musicpd and requests
>   * Add service file (systemd)
> 
> Regards,
> Geoff
>