❦ 9 septembre 2015 14:59 -0300, J.S.Júnior <j.s.junior@live.com> :
>> > Changes since the last upload:
>> [...]
>>
>> In d/copyright, you have the same clause for "*" and for "match.c" (and
>> others).
>
> I had left "*", but lintian asked to be explicit to the files.
>
> W: mini-httpd source: file-without-copyright-information
> and more
That's odd. So, OK.
>> In d/mini-httpd.install, you install files in /var/www/html. You should
>> not do that as another package could use it (which is likely not to be
>> the case, but you get the idea). It seems that the rule is to copy the
>> index.html from /usr/share/... to /var/ww/html/index.mini-httpd.html. I
>> don't know if this is a written policy somewhere.
>
> I'm rename index.html for index-mini-httpd.html
> See: Bug [1] and Discution [2], default for web servers.
The discussion seems to be about the default root. On my system, I have
both nginx and lighttpd and they both have their own file in
/var/www/html installed through postinst:
#v+
if [ ! -r /var/www/html/index.lighttpd.html ]; then
cp /usr/share/lighttpd/index.html /var/www/html/index.lighttpd.html
fi
#v-
I suppose there is a good reason for that.
>> > - Fix error set -e and no install htpasswd (Closes: #520941)
>>
>> Didn't look at the bug, but set -e is usually considered a bad idea in
>> an init script. For example, stuff like that wouldn't work (but you
>> don't have such a case in your init.d script, so you may ignore that):
>>
>> #v+
>> do_start
>> case "$?" in
>> ...
>> esac
>> #v-
>>
> I don't understand
> Look, if I remove, lintian send message.
> mini-httpd: maintainer-script-ignores-errors postinst
>
> Insert lintian overrides ? or no.
Oh, I thought this was about the "set -e" in the init.d script. In
postinst, you need to keep it. There is no rule for the one in init, so
you can leave as is. I just warn you that you may run into some
trouble. set -e is not set anymore in the most recentish skeleton script
(the one before the current one).
--
Debian package sponsoring guidelines:
http://vincent.bernat.im/en/debian-package-sponsoring.html
Attachment:
signature.asc
Description: PGP signature