On 24/07/15 15:49, Oxan van Leeuwen wrote:
> Hi,
>
> On 24-07-15 02:43, Cameron Norman wrote:
> >I see the prerm file is empty -- why not just delete it?
> Oops, that's a leftover from the switch to dh_apparmor. I've deleted it
> in the git repository.
>
> >Also, why do you patch the sysv-redhat init script if you end up using
> >the sysv-lsb one? I think you can drop that part of the patch.
> Yes, it's probably not that useful to keep that patch. It shouldn't
> hurt either though.
>
> >Finally, have you actually tested the AppArmor profile works on Debian?
> Yes, I've tested it.
>
> Cheers,
> Oxan
>
Hi guys,
I've tested the AppArmor profile too, it looks fine, although I'm not
sure if 'm' is needed in the profile for '/usr/sbin/postsrsd', since
it seems to work just fine without it. I've a rather basic knowledge
about AppArmor, so if you could explain it to me, I'd be grateful.
And the last thing: in the systemd unit, you do:
-d$${SRS_DOMAIN:-$$(postconf -h mydomain 2>/dev/null)}
Well, first if SRS_DOMAIN is set to something that it's fine, if it's not,
then postconf is used to get the mail server domain. But postconf may not
be present! You probably need to depend on postfix, unless postsrsd can be used
with other mail software.
I'd also recommend using EnvironmentFile in your systemd unit [1].
I also pushed some minor fixes.
When this is done, I'll be happy to push your package,
I already use it myself for some time :).
Great work,
Tomasz
[1] https://fedoraproject.org/wiki/Packaging%3aSystemd#EnvironmentFiles_and_support_for_.2Fetc.2Fsysconfig_files
Attachment:
signature.asc
Description: Digital signature