[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#795224: RFS: sndio/0.0.10-1 [ITP] -- Small audio and MIDI framework from OpenBSD



1) d/changelog:
sndio (0.0.10-1) UNRELEASED; urgency=low


(feel free to spot the error :) )

Interesting, I had thought that was supposed to be changed only right before the "real" upload. Next will be for unstable, anyhow.

2) d/rules:
I would prefer to run dh_auto_configure -- instead of ./configure

but it should be the same...
(actually dh_auto_configure fails, because it adds something that is not recognized by
the hand written configure script)

I think this should probably stay the same. dh_auto_configure(1) doesn't seem to describe any mechanism to suppress the auto-added arguments, and in fact encourages a direct call to ./configure if it doesn't work...

3) d/docs: empty?

Drat, thanks for catching. (All documentation for this package is in manpage form, so d/docs will just go away entirely)

4) d/libsndio6.0.symbols


you seem to export something like:
strlcat@Base 0.0.10
strlcpy@Base 0.0.10


are you sure? you can just depend on libbsd-dev and link it

The next upload will have a patch for that, which has already been sent upstream (and will probably be in the next upstream release). There is unfortunately still one bsd-compat function (fortunately used only inside libsndio, so it can reasonably be hidden upstream in the future) that libbsd doesn't provide (issetugid - can only be implemented in a crude and incorrect way outside of kernel space, which is probably why libbsd doesn't bother)

5) d/libsndio-dev.install

usr/share/man/man3/*.3


this has to be handled by a libsndio-dev.manpages
man dh_installman helps :)

<snip>

7) d/{sndiod.,sndio-tools,sndio-xtools}.install :
same contains manpages

Thanks for the hint.

6) d/sndiod.init:

this should be part of upstream, seems to be not Debian specific...
what about forwarding it there?

It is in fact based on upstream's example script with minor changes; what I'll do for now is apply them the Right Way with a patch (again a diff has been sent upstream).

let me know how you want to address the above, and I'll look again at
the package :)
I'll make another upload on mentors in a few hours, hopefully with all of these issues corrected.


Reply to: