Bug#793651: Quick review

[Gianfranco Costamagna <costamagnagianfranco@yahoo.it>]

Hi, I can't yet sponsor your package, but I can give you a quick review.

I honestly do not like custom makefiles, because even if you handle the build flags, you do not handle e.g. the install DESTDIR
variable and prefix one correctly.

This is why you overridden the dh_auto_install variable.

I suggest you to create an easy CMakeLists.txt file and use it, allowing to easily use the dh calls without any override.

$ cat CMakeLists.txt
add_executable(hdump hdump.c)
install(TARGETS hdump DESTINATION bin)


this way you can just add cmake to build dependencies,
remove the install file and the override in your rules file.

this will avoid also having an hdump binary file in your source directory
(I don't know, I built it and it didn't disappear from the source directory, giving a lintian warning)

cheers,

Gianfranco