[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#782847: RFS: endless-sky/0.8.0-1 [ITP]



On Tue, Jul 21, 2015 at 10:50:23PM -0400, Michael Zahniser wrote:
>  * Package name    : endless-sky

I'm afraid it fails to build in sbuild, because the first alternative in
"libjpeg-turbo8-dev | libjpeg62-turbo-dev" is notexistant, and sbuild
ignores everything but the first, per the buildd policy.  And sbuild is
what the autobuilders use...

I wonder, why do you depend on particular versions of libjpeg?  Do you
happen to use libjpeg-turbo extensions, or just want a fast optimized
version?  If the latter, it'd be better to declare a dependency on just
"libjpeg-dev", which on jessie or higher means jpeg-turbo but will degrade
to libjpeg8 if someone wants a backport to wheezy.


Lintian says:
W: endless-sky source: dep5-copyright-license-name-not-unique (paragraph at line 76)
W: endless-sky source: dep5-copyright-license-name-not-unique (paragraph at line 82)
W: endless-sky source: dep5-copyright-license-name-not-unique (paragraph at line 88)
W: endless-sky source: dep5-copyright-license-name-not-unique (paragraph at line 165)
W: endless-sky source: dep5-copyright-license-name-not-unique (paragraph at line 184)
W: endless-sky source: dep5-copyright-license-name-not-unique (paragraph at line 189)
W: endless-sky source: dep5-copyright-license-name-not-unique (paragraph at line 194)
W: endless-sky source: dep5-copyright-license-name-not-unique (paragraph at line 199)
W: endless-sky source: dep5-copyright-license-name-not-unique (paragraph at line 561)
W: endless-sky source: dep5-copyright-license-name-not-unique (paragraph at line 875)

This is because you use paragraphs like:
.----
License: CC-BY-SA-3.0
 (creativecommons.org/licenses/by-sa/3.0)
 Taken from Wikimedia commons. Cropped and edited.
`----
You want instead:
.----
License: CC-BY-SA-3.0
Comment: Taken from Wikimedia commons. Cropped and edited.
`----
as the definition of what "CC-BY-SA-3.0" means is already included.


Also, single-threaded build is _slow_.  This may be fixed by using:
.----
ifneq (,$(findstring parallel,$(DEB_BUILD_OPTIONS)))
       PROCS=$(patsubst parallel=%,%,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
       SCONS_OPTIONS += -j$(PROCS)
endif
`----
then changing scons invocations to $(SCONS) $(SCONS_OPTIONS)


Also, the .desktop entry doesn't show in the menu for me (XFCE), I have no
idea why, though.

-- 
⢎⣉⠂⠠⠤⡀⣄⠤⡀⠠⡅⠀⠤⡧⠄⡄⠀⡄⠀⠀⠀⠠⡅⠀⡠⠤⠄⠀⠀⠀⢴⠍⠀⡠⠤⡀⣄⠤⡀⠀⠀⠀⠤⡧⠄⣇⠤⡀⡠⠤⡀⠀⠀⠀⡄⠀⡄⡠⠤⡀⠠⠤⡀⡇⡠⠄⠀⠀⠀
⠢⠤⠃⠪⠭⠇⠇⠀⠇⠀⠣⠀⠀⠣⠄⠨⠭⠃⠀⠀⠀⠀⠣⠀⠬⠭⠂⠀⠀⠀⠸⠀⠀⠣⠤⠃⠇⠀⠀⠀⠀⠀⠀⠣⠄⠇⠀⠇⠫⠭⠁⠀⠀⠀⠣⠣⠃⠫⠭⠁⠪⠭⠇⠏⠢⠄⠀⠄⠀
(https://github.com/kilobyte/braillefont for this hack)


Reply to: