[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#792443: RFS: mirage/0.9.5.1-4 [QA]



All right now. Uploaded to mentors,

On Tue, Jul 14, 2015 at 10:05 PM, Eriberto Mota <eriberto@debian.org> wrote:
tags 792443 moreinfo
thanks


Hi Lucas,

I will try help you. My considerations:

1. I can see some changes not registered in d/changelog. An example of
this is DH level change (from 7 to 9). I used the 'debdiff' command to
see the changes. Other files: debian/mirage.postinst,
debian/patches/remove_gimp_remote.patch, debian/pycompat

2. d/changelog:

- I suggest you to organize better the ideas. Try to use a logical
order. You can sort the itens by events (Added, Changed, Removed,
Updated, etc) or by main events followed by files (debian/control,
debian/copyright, etc). For the latter case, you can see an example
here[1].

- Please, remove the unnecessary double spaces.

- Use debian/<file> for all files inside the debian/ directory, as
debian/watch ans debian/patches/desktop_entry_issue.patch.

- Use '$ spell changelog | sort -u' and '$ spell control | sort -u' to
search for spelling errors, as 'Dependeces'.

[1] http://metadata.ftp-master.debian.org/changelogs/main/l/lime-forensics/unstable_changelog

3. d/control: you found a new upstream homepage to use in d/watch. So,
why you removed the Homepage field from d/control?

4. debian/copyright:

- The "updated" notice in d/changelog is a bit generic because you did
several modifications.

- I found this text in upstream source code:

mirage-Mirage is free software; you can redistribute it and/or modify
mirage-it under the terms of the GNU General Public License as published by
mirage-the Free Software Foundation; either version 3 of the License, or
mirage-(at your option) any later version.

mirage.py-Mirage is free software; you can redistribute it and/or modify
mirage.py-it under the terms of the GNU General Public License as published by
mirage.py-the Free Software Foundation; either version 3 of the License, or
mirage.py-(at your option) any later version.

So, the source code is GPL-3+, not GPL-3. You need to use the
following command to check this situation:

$ egrep -sriA25 '(copyright|public dom)' *

- There are several authors in po/ directory.

- You must to list all packagers in debian/* block. You can use the
following command to search for all:

$ egrep '(--|\[)' debian/changelog

5. d/watch: your configuration produces notices about invalid
character in version number (two underscores).

6. You must always check the PTS[2] to search for bugs, tips etc. In
bugs list I can see a relevant bug that you can close: #773997.

[2] https://packages.qa.debian.org/m/mirage.html

Thanks for your work.

Regards,

Eriberto


2015-07-14 17:09 GMT-03:00 Lucas Castro <lucascastroborges@gmail.com>:
> Package: sponsorship-requests
> Severity: normal
>
> Dear mentors,
>
> I am looking for a sponsor for my package "mirage"
>
>    This orphaned packages required some lintian corrections and I had done,
>    it already has two P lintians, but it is its homepage fields and signature
>    that I didn't found.
>
> * Package name    : mirage
>   Version         : 0.9.5.1-4
>   Upstream Author : [fill in name and email of upstream]
>   * URL             : [fill in URL of upstreams web site]
>   * License         : [fill in]
>   Section         : graphics
>
>   It builds those binary packages:
>
>     mirage     - fast and simple GTK+ image viewer
>
>   To access further information about this package, please visit the following URL:
>
>   http://mentors.debian.net/package/mirage
>
>   Alternatively, one can download the package with dget using this command:
>
>     dget -x http://mentors.debian.net/debian/pool/main/m/mirage/mirage_0.9.5.1-4.dsc
>
>   More information about hello can be obtained from http://www.example.com.
>
>   Changes since the last upload:
>
>     * QA upload.
>     * Updated watch
>     * debian/control
>         - Bumped Standards-Version to 3.9.6
>         - Homepage removed
>     * debian/copyright updated
>     * Added desktop_entry_issue.patch: Avoid desktop-entry-lacks-keywords-entry.
>     * Build-Dependeces: added  dh-python.
>
> -- System Information:
> Debian Release: 8.1
>   APT prefers stable-updates
>   APT policy: (500, 'stable-updates'), (500, 'stable')
> Architecture: amd64 (x86_64)
> Foreign Architectures: i386
>
> Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
> Locale: LANG=pt_BR.utf8, LC_CTYPE=pt_BR.utf8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: systemd (via /run/systemd/system)
>
>
> --
> To UNSUBSCRIBE, email to debian-mentors-REQUEST@lists.debian.org
> with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
> Archive: [🔎] 20150714200940.16904.79999.reportbug@debian" rel="noreferrer" target="_blank">https://lists.debian.org/[🔎] 20150714200940.16904.79999.reportbug@debian
>



--
contatos:
Celular: ( 99 ) 9143-5954 - Vivo
skype: lucasd3castro
msn: lucascastroborges@hotmail.com

Reply to: