[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#788844: RFS: gbutils/5.6.6-1 [ITP]



Hi Tomasz,

thank you very much for your careful review.

Il giorno mar, 30/06/2015 alle 13.58 +0200, Tomasz Buchert ha scritto:
> On 30/06/15 12:35, Pietro Battiston wrote:
> > 
> > [...]
> 
> Hi,
> here are a few notes:
> 
>   * you install manpages 2 times

Ouch! Fixed.

>   * the files in the 'lib' directory have copyright that is not 
> mentioned
>     in d/copyright (e.g., "Written by Simon Josefsson" in 
> lib/getline.h)
>     (it seems that lib/ is not used on GNU systems, but still)
> 

Fixed too, thanks for noticing.

> There is also the "issue" of polluting $PATH with so many binaries,
> but I don't think it's a formal requirement. I think it would be 
> better
> to have "gbutils plot ..." interface.
> 

This I think is unavoidable. Typically, running analyzes with such
utilities involves calling several of them in a same bash command...
the fact that each can be called with a short and intuitive sequence of
digits is crucial. Something like "gb rand" rather than "gbrand"
_could_ in principle work, but I don't think I would prefer it, both
for ease of use and because installing a two-chars executable would
actually, to my eyes, create more pollution (increase the probability
of clashes).

That said, the fixed package is still at
http://mentors.debian.net/debian/pool/main/g/gbutils/gbutils_5.6.6
-1.dsc

I also uploaded the packaging repo to Alioth, something previously I
had forgot to do:
git://anonscm.debian.org/collab-maint/gbutils.git

Cheers,

Pietro


Reply to: