[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#791901: RFS: frozen-flask/0.11-1 [ITP]



+++ Orestis Ioannou [2015-07-09 13:24 +0200]:
> python-frozen-flask - Freezes a Flask application into a set of static
> files.
> python3-frozen-flask - Freezes a Flask application into a set of static
> files.

OK, I'd like to see these in debian, so I took a look.

>   http://mentors.debian.net/package/frozen-flask

Comments:

1) You've licenced the debian files (GPL-2+) differently from the 
   upstream file (BSD-3). That's OK if you only want to contribute on
   a GPL basis, but if you don't have strong feelings it usually best
   to put the debian packaging under the same licence as upstream,
   just for simplicity.

2) The artwork has a different licence but this is not recorded in the
   copyright file.

3) No Homepage or vcs fields in the control file

4) No multi-arch metadata in the control file
(The binary packages should be Multi-Arch: foreign in this case)

Otherwise it looks good.

I know very little about python and less about its packaging so I
don't know if there are things missing - I'm assuming that:
export PYBUILD_NAME=frozen-flask
%:
        dh $@ --with python2,python3 --buildsystem=pybuild

will just DTRT

Someone with some python-clue could perhaps take a look (and would be
a better sponsor in that regard)

Wookey
-- 
Principal hats:  Linaro, Debian, Wookware, ARM
http://wookware.org/


Reply to: