Thanks for review. Please, review again and compare with my vision what is done. > As this is on my TODO list for check-all-the-things, I'm willing to > review and sponsor. In exchange for the upload, I will require a patch > for check-all-the-things to support complexity. Okay, I will make the patch. > These issues are blockers for uploading: > > doc/gendocs_template says it is licensed under the CC-BY-ND-3.0 > license, which doesn't allow derivatives and is not a free license. > > debian/copyright is missing the embedded code copies in lib and m4. I > don't know if the ftpmasters will require those to be present but I > would suggest to document them anyway. Repacked and fixed. > These issues would be nice to fix: > > You might want to use upstream's xz tarballs, they are smaller. Done. > > debian/upstream/signing-key.pgp should be renamed .asc Done. > > Please ask upstream to include doc/mk.sh in the tarball. In TODO. > > Personally I would wrap debian/watch at the space (use a \). Done. > > Please send upstream a patch to not install cx-vs-mc. In TODO. > > I would suggest using https in all the debian/copyright URLs. Done. > > I would suggest running wrap-and-sort -sa Done. > > DH_VERBOSE is not normally turned on in debian/rules. Done. > > tests/complexity.test should use mktemp instead of referencing /tmp > src/char-types.map has a typo: caracter => character Not a issue, imho. > I would suggest using dh-autoreconf instead of autotools-dev. Done. > The code in src/ appears to get compiled three times, once in > dh_auto_build, once in dh_auto_test and once in dh_auto_install. In TODO to inform upstream. > The following are generated files and should be removed before > dh_auto_configure and rebuilt during the build process. Personally I > would suggest all of them should be removed from the upstream VCS and > the ones that aren't autotools requirements should be removed from the > upstream tarballs. > > aclocal.m4 > bootstrap > src/char-types.h > configure > config.h.in > Makefile.in > */Makefile.in > lib/Makefile.am > doc/complexity.info > doc/gendocs_template > doc/invoke-complexity.texi Some of them are gone as result of repack. > The following are embedded code copies and should be removed before > dh_auto_configure and copied in from build-dependencies. > > lib > m4 Done. > You may want to add some upstream metadata: > > https://wiki.debian.org/UpstreamMetadata In TODO. > $ duck > E: debian/control: Vcs-Git: git://anonscm.debian.org/users/kaction-guest/complexity.git: ERROR (Certainty:certain) > fatal: '/git/users/kaction-guest/complexity.git' does not appear to be a git repository > fatal: Could not read from remote repository. > > Please make sure you have the correct access rights > and the repository exists. Major issue. Infrastructure problem. Wrote to admins, waiting for response. > E: debian/control: Homepage: https://gnu.org/software/complexity: ERROR (Certainty:certain) > Curl:56 HTTP:0 Failure when receiving data from the peer gnutls_handshake() warning: The server name sent was not recognized > > E: debian/copyright:3: URL: https://gnu.org/software/complexity: ERROR (Certainty:possible) > Curl:56 HTTP:0 Failure when receiving data from the peer gnutls_handshake() warning: The server name sent was not recognized Done. -- Accept: text/plain, text/x-diff Accept-Language: eo,en,ru X-Keep-In-CC: yes
Attachment:
pgplPTNc5VO3J.pgp
Description: PGP signature