[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#789712: RFS: pylint-celery/0.3-1 [ITP]



Hi Daniel,

On Tue, 23 Jun 2015 20:20:34 Daniel Stender wrote:
> I'm seeking for an uploader resp. sponsor of my package of pylint-celery

I'm not sure if I'll be able to sponsor your package but I had a quick look 
and spotted a problem in packaging: it is incorrect to override 
DEB_BUILD_OPTIONS from "debian/rules". DEB_BUILD_OPTIONS should be available 
to whoever builds your package to override default behaviour (for example 
disable tests, etc.).
Correct way to disable tests is by using "override_dh_auto_test" where
you can invoke "-dh_auto_test" (that's right, with "minus" character) to run 
tests but continue on their failures. If some tests are meaningful it might be 
useful to run them in order to capture tests output in build logs.

Also I believe the correct name of the license is "GPL-2" instead of 
"GPL-2.0".

Finally I have some doubts whether this tiny plugin is worth exposing system-
wide -- if it is only used by Pylint then perhaps it could be installed 
privately? Isn't that what Python team policy says?

-- 
Regards,
 Dmitry Smirnov
 GPG key : 4096R/53968D1B

---

Continuous effort - not strength or intelligence - is the key to unlocking
our potential.
        -- Winston Churchill

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: