[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#788214: RFS: clblas/2.4-1 [ITP Bug#786505] -- OpenCL BLAS library



Hi Fred,

Thanks for checking my package out.

My comments are below:

2015-06-17 8:46 GMT+01:00 PICCA Frederic-Emmanuel <frederic-emmanuel.picca@synchrotron-soleil.fr>:
Hello,

I go thtese lintian errors

lintian
───────

E: clblas source: missing-build-dependency dpkg-dev (>= 1.16.1~)
N:
N:    The package doesn't specify a build dependency on a package that is used
N:    in debian/rules.
N:
N:    lintian intentionally does not take into account transitive
N:    dependencies. Even if the package build-depends on some package that in
N:    turn depends on the needed package, an explicit build dependency should
N:    be added. Otherwise, a latent bug is created that will appear without
N:    warning if the other package is ever updated to change its dependencies.
N:    Even if this seems unlikely, please always add explicit build
N:    dependencies on every non-essential, non-build-essential package that is
N:    used directly during the build.
N:
N:    Refer to Debian Policy Manual section 4.2 (Package relationships) for
N:    details.
N:
N:    Severity: serious, Certainty: possible
N:
N:    Check: rules, Type: source
N:

and these important point.

personnaly I find it not convenient to maintain symbols files for C++ library.
so can you fix the other points.


For some reason, neither my lintian nor the QA check on d-mentors raises this error. I
understand the rationales for it and added the appropriate bdep to the source package. 
 

I: libclblas2: spelling-error-in-binary usr/lib/i386-linux-gnu/libclBLAS.so.2.4.0 dont don't
N:
N:    Lintian found a spelling error in the given binary. Lintian has a list
N:    of common misspellings that it looks for. It does not have a dictionary
N:    like a spelling checker does.
N:
N:    If the string containing the spelling error is translated with the help
N:    of gettext or a similar tool, please fix the error in the translations
N:    as well as the English text to avoid making the translations fuzzy. With
N:    gettext, for example, this means you should also fix the spelling
N:    mistake in the corresponding msgids in the *.po files.
N:
N:    You can often find the word in the source code by running:
N:
N:     grep -rw <word> <source-tree>
N:
N:    This tag may produce false positives for words that contain non-ASCII
N:    characters due to limitations in strings.
N:
N:    Severity: minor, Certainty: wild-guess
N:
N:    Check: binaries, Type: binary, udeb
N:

I'll send a patch upstream, but I don't think it is worth adding a patch to the packaging for
such a harmless issue.

E: libclblas2: missing-pre-dependency-on-multiarch-support
N:
N:    The package ships a library in one of the multiarch lib directories,
N:    /lib/<triplet> and /usr/lib/<triplet>, but does not declare a
N:    pre-dependency on multiarch-support. Packages installing to these paths
N:    must Pre-Depend: multiarch-support to ensure the library can be found by
N:    the dynamic linker at every point during an upgrade.
N:
N:    Severity: serious, Certainty: certain
N:
N:    Check: files, Type: binary, udeb
N:

This one I am not quite sure what to think. Add the multiarch-support explicitly to Pre-Depends
now raises the following lintian message:

P: clfft source: pre-depends-directly-on-multiarch-support libclfft2
N:
N:    The control file mentions multiarch-support in a Pre-Depends line.
N:    Usually multiarch-support is inserted into Pre-Depends via
N:    ${misc:Pre-Depends} by dh_makeshlibs. In order to be able to remove the
N:    multiarch-support package from glibc without updating every package,
N:    Pre-Depends: ${misc:Pre-Depends} should be used instead. Then
N:    multiarch-support can be removed by a change in debhelper followed by a
N:    binNMU of all affected packages.
N:   
N:    Severity: pedantic, Certainty: possible
N:   
N:    Check: control-file, Type: source
N:

According to the documentation in https://wiki.debian.org/Multiarch/Implementation,

Explicit Pre-Depends on multiarch-support was necessary for Wheezy (hence the use of the word "must").
However, the instructions given at the end of the page clearly state that I should be using ${misc:Pre-Depends}
instead.

So I am not sure what to do with these conflicting pieces of information. Besides, my lintian does not complain
about it in the current state of the packaging, neither is the problem raised on d-mentors.
 
I: libclblas2: no-symbols-control-file usr/lib/i386-linux-gnu/libclBLAS.so.2.4.0
N:
N:    Although the package includes a shared library, the package does not
N:    have a symbols control file.
N:
N:    dpkg can use symbols files in order to generate more accurate library
N:    dependencies for applications, based on the symbols from the library
N:    that are actually used by the application.
N:
N:    Refer to the dpkg-gensymbols(1) manual page and
N:    http://wiki.debian.org/UsingSymbolsFiles for details.
N:
N:    Severity: wishlist, Certainty: certain
N:
N:    Check: shared-libs, Type: binary, udeb
N:


I agree with you on the symbols.


Cheers

Frederic

On a general note, I'd be curious to know why your setup raised all these additional errors compared to
d-mentors and mine. Just to know what I am doing wrong, if anything.

Best regards,

Ghis

Reply to: