[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#785737: RFS: haxe/1:3.0.0~svn6707+dfsg-1 [ITA,RC]



On Fri, May 22, 2015 at 10:26:00AM +0000, Jean-Michel Vourgère wrote:
> Hello

Hi, thanks for reviewing.
 
> Gabriele Giacone wrote:
> >  haxe (1:3.0.0~svn6707+dfsg-1) unstable; urgency=medium
> > 
> >   * Adopt as Debian Flash Team.
> >     + Set maintainer to Debian Flash team, add myself to uploaders.
> >   * Set Vcs-* fields to updated collab-maint git repo.
> >   * Replace jquery-latest.min.js and swfobject.js with symlinks to system ones.
> >     + Remove sourceless files from upstream tarball (Closes: #736596).
> >     + Add libjs-jquery and libjs-swfobject runtime dependencies.
> >   * Bump Standards-Version to 3.9.6 (no changes).
> 
> You added a +dfsg suffix. Good.
> 
> However, lintian is complaining about the +dfsg :
> debian-watch-file-should-mangle-version.

Fixed, pushed, re-uploaded.
 
> You should update the watch file to match your change.
> Please also look at repacksuffix in uscan(1).
> 
> When removing some non-free files, you should provide a get-orig-source
> target in your rules file. The easiest way to remove files is to use a
> DEP5 formated copyright file and to have a line Files-Excluded:. See
> uscan(1).

Yeah I've just did it few days ago for ming, convenient.
 https://anonscm.debian.org/cgit/pkg-flash/ming.git/commit/?id=f7531971a4dd6f37520bc3fe66421e9bea8ed396

In this case, I've changed packaging as little as possible: no new
upstream release, no format 1.0 copyright, no Files-Excluded.
Mainly just to fix RC bug #736596.

> Everything else is ok to me.
> 
> It's nice that package finally fond an adoption team. :)

Well, unfortunately lately team is just me, also without upload rights.
Haxe is not flash specific software but gnash testsuite depends on it.
No problem about moving it to collab-maint if preferred.

Thanks,
-- 
G..e


Reply to: