Hi Vincent, Thx for your review! > debian/copyright is missing a few entries: > - src/serial/*: Copyright 1997-2001 John E. Stone (j.stone@acm.org), > 3-clause BSD (+ upstream author) Should be fixed. > debian/stamp-patched is useless and can be removed. Done. > debian/patches/run.patch is rather redundant; /var/run is not going to > be removed from Debian in the foreseeable future and will likely be > kept around for compatibility reasons for a long time. If you do > decide to keep it though, please look into adding DEP-3 [1] headers > for it (and any future patch you add). As it is not too invasive, I choose to keep it, I just added a simple header. > Your package isn't actually hardened. "export DEB_BUILD_MAINT_OPTIONS > = hardening=+all" in d/rules isn't going to do anything if your > package's build system ignores the hardening flags set by > dpkg-buildflags. Right, I have seen this but I did not know how to deal with. I plan to propose an update build system (cmake) to upstream dev but for now, I added a debian specific patch. An updated package has been sent on http://mentors.debian.net/package/spacenavd if you want to check again. Regards, Rodolphe
Attachment:
signature.asc
Description: OpenPGP digital signature