Bug#784732: RFS: liquidprompt/1.9-1 [ITP]

[Vincent Cheng <vcheng@debian.org>]

Control: tag -1 + moreinfo
Control: owner -1 !

Hi Arturo,

On Fri, May 8, 2015 at 1:08 AM, Arturo Borrero Gonzalez
<arturo.borrero.glez@gmail.com> wrote:
> Package: sponsorship-requests
> Severity: wishlist
>
> Dear mentors,
>
> I am looking for a sponsor for my package "liquidprompt"
>
> * Package name    : liquidprompt
> * Version         : 1.9
> * Upstream Author : Nojhan <nojhan@nojhan.net>
> * URL             : https://github.com/nojhan/liquidprompt
> * License         : AGPL-3
> * Programming Lang: shell
> * Section         : misc
>
> It builds those binary packages:
>  liquidprompt - adaptative prompt for bash & zsh
>
> To access further information about this package, please visit the
> following URL:
>  http://mentors.debian.net/package/liquidprompt
>
> Alternatively, one can download the package with dget using this command:
>  dget -x http://mentors.debian.net/debian/pool/main/l/liquidprompt/liquidprompt_1.9-1.dsc
>
> More information about hello can be obtained from
> https://github.com/nojhan/liquidprompt.

Just a few more things to add to Andrey's earlier review:

- Don't hardcode a reference to $HOME/.config in
liquidprompt_activate, use $XDG_CONFIG_HOME instead [1].
- If your package is covered by a license that does not have the full
text stored in /usr/share/common-licenses, you should include the full
text yourself in d/copyright.

I also share Andrey's concern about the multiple invocations of
liquidprompt_activate polluting bashrc/zshrc, although I don't
consider that a blocker for an upload.

Regards,
Vincent

[1] http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html