Hi Ross, first thanks for your review. Am Samstag, den 11.04.2015, 19:56 +0200 schrieb Ross Gammon: > Hi Jörg, > > I am glad to see you working on this, as one of my packages will > eventually depend on python-instagram! > > On 04/06/2015 11:31 PM, Jörg Frings-Fürst wrote: > Therefore, I thought I would give you a review for what it is worth (I > am not a DD so I cannot sponsor it): > > - The package builds fine in a chroot and the clean target is working fine. > - piuparts reports no problems. > - Lintian is happy. > - The watch file is not working, but that is okay as upstream do not do > releases or tags. > > I am wondering why d/control has "Provides: ${python:Provides}"? Python > Policy mentions it (and generally discourages its use). Mainly I am > curious about it. > I have found it at [1]. > One minor comment about d/copyright is that according to the upstream > README & LICENSE files, the copyright says "2014, Facebook, Inc." (not > Instagram, and not in 2015) > Changed and uploaded. > I also noticed that setup.py still says MIT (not reflecting the recent > change to BSD). You might want to report that upstream. > > Here's hoping you find a sponsor soon. > I have open a new issuse[2] about this. > Regards, > > Ross > > CU Jörg [1] https://wiki.debian.org/Python/Policy [2] https://github.com/Instagram/python-instagram/issues/142 -- New: GPG Fingerprint: 63E0 075F C8D4 3ABB 35AB 30EE 09F8 9F3C 8CA1 D25D GPG key (long) : 09F89F3C8CA1D25D GPG Key : 8CA1D25D CAcert Key S/N : 0E:D4:56 Old pgp Key: BE581B6E (revoked since 2014-12-31). Jörg Frings-Fürst D-54526 Niederkail Threema: SYR8SJXB IRC: j_f-f@freenode.net j_f-f@oftc.net My wish list: - Please send me a picture from the nature at your home.
Attachment:
signature.asc
Description: This is a digitally signed message part