Bug#780096: RFS: dyfi/1.2.0-1 [ITP #779708]
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hello Eugene,
I noticed your RFS ticket and made a short review about the package.
I'm not a DD so I can't sponsor your package but hopefully this
is useful for someone considering sponsorship.
So, the comments:
about debian/config:
- Is it necessary to have condition
if [ $1 = "configure" ]; then
..
fi
around db_input/db_go -commands? I'm under impression that this
config-script might be run also on other situations than config ;
or is this intentional?
about debian/copyright:
- According to
https://lists.debian.org/debian-devel-announce/2006/03/msg00023.html
you should have, among other things in the copyright file the authors
name and year of the copyright. Year is missing for "Files: *"
and then I'm not sure if "dy.fi admins" count as name of
author ; I understand that there may be real organization of
human behind dy.fi that have developed the sw but .. naming
a person, a company or other entity that may be recognized
by rule of law (in Finland?) might be a jolly good idea?
- There are "Files-Excluded" mentioned in copyright ; it might be
required to explicitly state that they may be distributed anyway,
for example using "permissive" license, if the files fall into
such category.
about debian/po/templates.pot Minor whining:
When username is queried, would it be nice to indicate that
this is exactly "dy.fi system username" and not just "username"
or is this going to be very clear in advance to person doing
the installation? I understood that the user account needs to
exists beforehand..
about debian/postinst
What is going to be file permission of /etc/dyfi-update.conf ?
It may contain user account + password to remote box?
general:
There is no documentation of any kind. Maybe a short manpage might
be in order?
The perl-script itself seems to start and start doing its job (I could not
really verify as I do not have dy.fi user account), also the daemon
is stopped upon uninstall (that is going to happen to a lot of users
who install this and then notice that service is available in finland only..).
- --
Antti Järvinen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Processed by Mailcrypt 3.5.8 <http://mailcrypt.sourceforge.net/>
iD8DBQFVGtyNUTdja+nNMWMRAoT7AJ46cYaIve87oib+T9YDeZWKPU6rzwCfQyL0
fHf3Hs2owx9VKKalPym6RTo=
=wzro
-----END PGP SIGNATURE-----
Reply to: