Bug#775509: Seeking Mentor for Bug#775509: RFS: tz-converter/1.0.0 ITP tz-converter
Hello Harlan,
Thank you very much for your reply and the advice.
For the copyright file, I have gone back and added a source for
Saki-NuoveXT-Apps-world-clock.ico. As for the icon "gnome-set-time.png",
I have grabbed this from the system, which looks to belong from the
package "gnome-desktop" licensed under GNU. As a result, I have added
the copyright owners of this package for the file
"icons/gnome-set-time.png". Please let me know if this needs to be
further reviewed.
Sorry for the PEP errors. I have the checks running with PyCharm, but
looks like I did not do a final run through before uploading. Made fixes
for the white spacing now.
For the "build" dir and the "changelog.Debian.gz" issues, not quite sure
how those got in there ;) Might have been from an older upload that I
did not fixed. Corrected these now.
I have taken all of these changes, and reposted to mentors.debian.net.
Please let me know if there is anything else, or how I can catch a
sponsor. I have been using Debian for almost 10 years, and want to be
able to contribute back :)
- Dave
On 金, 2015-03-27 at 14:59 -0400, Harlan Lieberman-Berg wrote:
> マイリノデイヴィッド <maiorinodavid@gmail.com> writes:
> > Bug#775509: RFS: tz-converter/1.0.0 ITP tz-converter
> Hello Dave!
>
> Thank you for your contribution to Debian. I'm not able to sponsor your
> package, but I took a look at it to see if there were things you could
> fix while you wait. (Some of these problems would traditionally be
> forwarded upstream and patched in Debian, but since you are also the
> upstream maintainer, a new release might be easier.)
>
> The most pressing concern to me is that the source for the two images
> included as icons is unclear. While the .ico file is referenced in
> d/copyright, including its source as a note is probably a good idea.
> The gnome-set-time.png icon has no listed license and should probably
> include the vector version if it is supplied by upstream - as the vector
> is the "preferred form of modification". This must be fixed before
> someone will sponsor it.
>
> The build directory should be removed from the upstream tarball.
> It's just duplicate code, and it gets removed by debhelper when the
> build is actually run anyway.
>
> pep8 shows a bunch of code formatting errors - mostly lines being too
> long and a couple of whitespace errors. You may be able to use a tool
> like autopep8 to correct the errors, though I suggest looking through
> the diff that it produces in case it does something wonky.
>
> Because you are both upstream and the Debian maintainer for the package,
> you should install the changelog file as changelog.gz, rather than
> changelog.Debian.gz. Take a look at Debian Policy 12.7 for more
> information.
>
> Thank you again for your contributions to Debian; I'm happy to take a
> second look after you have fixed these problems.
>
> Sincerely,
>
Reply to: